70464 - Add (or rather restore) the configure option to disable NSPR autoconf.

Status: VERIFIED WONTFIX

(SeaMonkey :: Build Config, defect, P2)

Description

[Wan-Teh Chang]

Mozilla's configure script is now assuming that NSPR must
be built with autoconf.  While this is true for the tip and
NSPRPUB_CLIENT_BRANCH of NSPR, older NSPR releases such as
NSPR 4.1 do not have the latest autoconf support (for example,
they do not allow running configure in the source tree) and
hence sometimes it is necessary to use their "classic" build
systems.

I am going to attach a patch that restores the dual NSPR
build system support in Mozilla's configure script.  Note
that I changed the configure option from --enable-nspr-autoconf
to --disable-nspr-autoconf to reflect the fact that autoconf
is the default NSPR build method for Mozilla.  The best way
to review my patch is to apply it and then compare mozilla/configure.in
with the revision right before we made autoconf the default
(and the only) build method on NSPRPUB_CLIENT_BRANCH, that is:
    % patch < thepatchfile
    % cvs -q diff -u -r1.784 mozilla/configure.in

The patch also modifies mozilla/allmakefiles.sh.  Note that
for simplicity the patch does not include the changes to
mozilla/configure, which you'll need to generate manually.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 2

[Wan-Teh Chang]

Output of 'cvs -q diff -u -r1.784 mozilla/configure.in' after
the patch is applied.  Note that the only effective change is
from --enable-nspr-autoconf to --disable-nspr-autoconf if you
ignore the checkins in rev. 786-787.

Index: mozilla/configure.in
===================================================================
RCS file: /cvsroot/mozilla/configure.in,v
retrieving revision 1.784
diff -u -r1.784 configure.in
--- configure.in	2001/02/22 02:59:13	1.784
+++ configure.in	2001/02/28 16:19:46
@@ -581,7 +581,9 @@
     _PEDANTIC=
     _IGNORE_LONG_LONG_WARNINGS=
     case $OS_RELEASE in
-	4.*) ;;
+	4.*)
+            STRIP="$STRIP -d"
+            ;;
 	*)
 	    DSO_CFLAGS=''
 	    DSO_LDOPTS='-r'
@@ -811,7 +813,7 @@
 	dnl Hack...
 	_OPENVMS_CROSS_COMPILE=1
     fi
-    NSPR_LIBS="-lnspr$NSPR_VERSION -lplc$NSPR_VERSION -lplds$NSPR_VERSION"
+    MISSING_NSPR="yes"
     AC_DEFINE(NO_PW_GECOS)
     AC_DEFINE(NO_UDSOCK)
     USE_PTHREADS=1
@@ -2150,6 +2152,14 @@
 			AC_DEFINE(_REENTRANT) 
 			;;
 
+	    *-aix4.3*)
+			AC_DEFINE(_REENTRANT) 
+			;;
+
+	    *-hpux11.*)
+			AC_DEFINE(_REENTRANT) 
+			;;
+
         *-*-os2*)
             USE_PTHREADS=
             _PTHREAD_LDFLAGS=
@@ -3696,10 +3706,10 @@
 [  --enable-idlc           Build idl tool (default=no) ],
   BUILD_IDLC=1)
 
-USE_NSPR_AUTOCONF=
-MOZ_ARG_ENABLE_BOOL(nspr-autoconf,
-    [  --enable-nspr-autoconf  Use autoconf when building nspr],
-    USE_NSPR_AUTOCONF=1)
+USE_NSPR_AUTOCONF=1
+MOZ_ARG_DISABLE_BOOL(nspr-autoconf,
+    [  --disable-nspr-autoconf  Do not use autoconf when building nspr],
+    USE_NSPR_AUTOCONF=)
 
 MOZ_ARG_ENABLE_BOOL(xterm-updates,
 [  --enable-xterm-updates  Update XTERM titles with current command.],

Comment 3

[cls]

I'd rather not add that as a visible option as it will not work with the tip
builds and is sure to generate more bug reports.  I suggest using a hidden
option like USE_CLASSIC_NSPR in the env (or .mozconfig) to trigger it.  Even
better would be to just require older versions to compile nspr beforehand and
use --with-nspr to build mozilla so that we avoid adding this clutter back into
configure.in.

Comment 4

[Wan-Teh Chang]

In that case I'll just back up to the revisions before you set
autoconf as the default NSPR build method.

Are mozilla/configure.in, mozilla/configure, and mozilla/allmakefiles.sh
the only files that were changed?

Comment 5

[cls]

Those 3 plus mozilla/client.mak .
 

Comment 6

[cls]

Marking wontfix per previous comments.

Comment 7

[Jon Granrose]

verified wontfix.