704718 - Send Android version in AUS pings instead of Linux kernel version

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

When pinging for updates, the Linux kernel version is sent as the %OS_VERSION% part of the URL. This is kinda useless. We should send the Android version instead.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

I don't think so, at least not for updates:

https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/UpdateServiceHelper.java.in#76

But for the blocklist there's:

https://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#198
https://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/nsBlocklistService.js#426
https://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/nsBlocklistService.js#98

I fixed the latter by landing bug 799228, but doesn't this mean that this URL never worked before? Or does the server-side ignore everything from a certain part on and just keeps it for statistical tracking?

Looks like this is resolved fixed depending on 799228, right?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Gian-Carlo Pascutto (:gcp) from comment #1)
> I don't think so, at least not for updates:
> 
> https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/
> UpdateServiceHelper.java.in#76

This bug is only really about the AUS (update) URL, and you're right. The above code, which landed with the Java Updater, fixes this bug.

> But for the blocklist there's:
> 
> https://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.
> js#198
> https://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/
> nsBlocklistService.js#426
> https://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/
> nsBlocklistService.js#98
> 
> I fixed the latter by landing bug 799228, but doesn't this mean that this
> URL never worked before? Or does the server-side ignore everything from a
> certain part on and just keeps it for statistical tracking?

All the data is kept, but it's only used for metric tracking. We don't act on the data.

> Looks like this is resolved fixed depending on 799228, right?

Well, this bug is probably fixed by Snorp's updater changes and we (I) forgot to close this out. We'll know soon if bug 799228 negatively affects  blocklist pings, but I doubt it will.