mozlog custom levels cause hard to read log files

RESOLVED FIXED

Status

Product:
Testing
Component:
Mozbase
Status:
RESOLVED FIXED
Reported:
7 years ago
Modified:
7 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Patch 1.0 - Fix level aligning
2.54 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

•
7 years ago 
The levels are all a different length which causes the log file to be hard to read.

Example (BEFORE):
PEP TEST-START | test_contextMenu.js
PEP WARNING | test_contextMenu.js | content_reload | unresponsive time: 51 ms
PEP TEST-UNEXPECTED-FAIL | test_contextMenu.js | fail threshold: 0.0 | metric: 2.601
PEP TEST-END | test_contextMenu.js | finished in: 5887 ms
PEP TEST-START | test_openBlankTab.js
PEP WARNING | test_openBlankTab.js | close_blank_tab | unresponsive time: 81 ms
PEP TEST-UNEXPECTED-FAIL | test_openBlankTab.js | fail threshold: 0.0 | metric: 6.561
PEP TEST-END | test_openBlankTab.js | finished in: 1067 ms
PEP TEST-START | test_openBookmarksMenu.js
PEP WARNING | test_openBookmarksMenu.js | show_all_bookmarks | unresponsive time: 124 ms
PEP TEST-PASS | test_openBookmarksMenu.js | fail threshold: 40.0 | metric: 15.376
PEP TEST-END | test_openBookmarksMenu.js | finished in: 1062 ms
PEP TEST-START | test_searchGoogle.js
PEP WARNING | test_searchGoogle.js | enterText | unresponsive time: 59 ms
PEP TEST-UNEXPECTED-FAIL | test_searchGoogle.js | fail threshold: 0.0 | metric: 3.481
PEP TEST-END | test_searchGoogle.js | finished in: 1138 ms
PEP TEST-START | test_openWindow.js
PEP WARNING | test_openWindow.js | open_window | unresponsive time: 63 ms
PEP TEST-UNEXPECTED-FAIL | test_openWindow.js | fail threshold: 0.0 | metric: 3.969
PEP TEST-END | test_openWindow.js | finished in: 204 ms
PEP TEST-START | test_resizeWindow.js
PEP TEST-PASS | test_resizeWindow.js | fail threshold: 0.0 | metric: 0
PEP TEST-END | test_resizeWindow.js | finished in: 411 ms
PEP INFO | Test Suite Finished
(Assignee)

Comment 1

•
7 years ago 
Created attachment 576559 [details] [diff] [review]
Patch 1.0 - Fix level aligning

With this patch, the same output as above will look like (AFTER):
PEP TEST-START | test_contextMenu.js
PEP WARNING    | test_contextMenu.js | content_reload | unresponsive time: 50 ms
PEP WARNING    | test_contextMenu.js | content_back | unresponsive time: 87 ms
PEP TEST-UNEXPECTED-FAIL | test_contextMenu.js | fail threshold: 0.0 | metric: 10.069
PEP TEST-END   | test_contextMenu.js | finished in: 9521 ms
PEP TEST-START | test_openBlankTab.js
PEP TEST-PASS  | test_openBlankTab.js | fail threshold: 0.0 | metric: 0
PEP TEST-END   | test_openBlankTab.js | finished in: 925 ms
PEP TEST-START | test_openBookmarksMenu.js
PEP WARNING    | test_openBookmarksMenu.js | show_all_bookmarks | unresponsive time: 135 ms
PEP TEST-PASS  | test_openBookmarksMenu.js | fail threshold: 40.0 | metric: 18.225
PEP TEST-END   | test_openBookmarksMenu.js | finished in: 1182 ms
PEP TEST-START | test_searchGoogle.js
PEP TEST-PASS  | test_searchGoogle.js | fail threshold: 0.0 | metric: 0
PEP TEST-END   | test_searchGoogle.js | finished in: 945 ms
PEP TEST-START | test_openWindow.js
PEP TEST-PASS  | test_openWindow.js | fail threshold: 0.0 | metric: 0
PEP TEST-END   | test_openWindow.js | finished in: 200 ms
PEP TEST-START | test_resizeWindow.js
PEP TEST-PASS  | test_resizeWindow.js | fail threshold: 0.0 | metric: 0
PEP TEST-END   | test_resizeWindow.js | finished in: 416 ms
PEP INFO       | Test Suite Finished
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
(Assignee)

Comment 2

•
7 years ago 
master: https://github.com/ahal/mozbase/commit/6d695ee038f0ff759d131b2b613ebb5178043323
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.