704929 - Refresh of dashboard is removing browserid login

Status: VERIFIED FIXED

(Web Apps Graveyard :: AppsInTheCloud, defect, P2)

Description

[[e-mail] [:onecyrenus]]

Unsure if this is expected functionality or not, but a refresh of the webpage

myapps.mozillalabs.com causes browser id login to be presented.. essentially logging out the user for each refresh.

Comment 1

[Anant Narayanan [:anant]]

Perhaps we should persist the user session somehow?

Comment 2

[Ian Bicking (:ianbicking)]

Yes, it's been a bit of a question what we should persist I suppose.

If we persist the token that we get from the server, we can re-try it.  But we don't have as well defined a process when the token is expired.  Perhaps we should just do a GET immediately on load, and if it fails in 401 then consider ourselves logged out (as opposed to trying /verify on load).

Comment 3

[Ian Bicking (:ianbicking)]

Solution to be implemented:

Instead of saving the assertion, we should save the response from /verify, and dive right into making requests without reverifying the assertion on load.

Comment 4

[Ian Bicking (:ianbicking)]

https://github.com/mozilla/openwebapps/commit/bd721e9ebc91319802fd74cdeb1bcd67bf27277b

(Unfortunately I got distracted halfway through and ended up putting other changes in withthat commit)

Not yet merged or deployed.

Comment 5

[Ian Bicking (:ianbicking)]

deployed on myapps