Closed Bug 704956 Opened 14 years ago Closed 14 years ago

No wiki style update results are visible if no update is available

Categories

(Mozilla QA Graveyard :: Mozmill Automation, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

There is a bug in the update testrun which doesn't execute direct updates if the fallback update part fails. That happens across branches as you can see here: http://mozmill-archive.brasstacks.mozilla.com/#/update/reports There was only an update for aurora available, and in this case we run both the fallback and direct update. I will work on that immediately.
Actually what I see in the logs is: Report document created at 'http://mozmill-archive.brasstacks.mozilla.com/db/ac54daa0d81dc359b2eb91a2195bf142' list index out of range *** Removing repository '/var/folders/wd/zmy4z7xn7wd7sjq90z1y52f80000gn/T/tmpXK4BVk.mozmill-tests' We are trying to access a list item outside of the valid range. With the patch I will also improve the failure details.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Depends on: 704980
The index issue happened because of bug 704980. But even with it fixed we still don't print out the final results.
Summary: If fallback update fails no direct updates are performed → No wiki style update results are visible if no update is available
Attached patch Patch v1 — — Splinter Review
That patch ensures that we always print out the wiki style format on the command line. We were failing for the time being for various reasons. I have added more checks for valid arrays and simplified the code to make it better understandable. Tested under all possible circumstances with updates in the queue, no updates in the queue, and by aborting a testrun with Cmd+Q.
Attachment #576773 - Flags: review?(dave.hunt)
Attachment #576773 - Flags: review?(dave.hunt) → review+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: