704965 - [traceback] PaypalError: Bad refund status for [e-mail]: ALREADY_REVERSED_OR_REFUNDED

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Pick an app for which refund has been requested.
2. Grant the refund from PayPal UI
3. Try granting the refund from AMO UI


expected behavior:

actual behavior:
Traceback (most recent call last):

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/decorators.py", line 102, in wrapper
   return f(*args, **kw)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/decorators.py", line 94, in wrapper
   return f(*args, **kw)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/decorators.py", line 30, in wrapper
   return f(request, addon, *args, **kw)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/decorators.py", line 28, in wrapper
   return func(request, *args, **kw)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/decorators.py", line 34, in wrapper
   return fun()

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/decorators.py", line 26, in <lambda>
   *args, **kw)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/views.py", line 493, in issue_refund
   paypal.refund(txn_id, contribution.paykey)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/paypal/__init__.py", line 157, in refund
   d['refundStatus']))

PaypalError: Bad refund status for [e-mail]: ALREADY_REVERSED_OR_REFUNDED

Comment 1

[Andy McKay]

This is a good thing.

A nice error message to the user and a log that's written and no error email to us would be nice.

Comment 2

[Allen Short [:ashort]]

https://github.com/washort/zamboni/commit/064457adcbd94e7767192d5899ec19a1bf08ee54