704989 - add workaround for broken Outlook Web App (OWA) attachment handling

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Julian Reschke]

The fix for bug 692574 breaks Exchange 2010'S Outlook Web Access, which apparently sends header in the form:

Content-Disposition:attachment; filename*="Manuale%20installazione%20aggiornamento%20ORACOLO_BATCH%20V1.0.docx"

See also <https://bugzilla.mozilla.org/show_bug.cgi?id=703015#c32>.

We will need to back out the change for bug 692574 for now.

Comment 1

[Julian Reschke]

The same applies to bug 685192.

Comment 2

[Julian Reschke]

Attachment: restore previous code, update test cases

This reverts the two code changes, but keeps the test cases, noting the changed results.

Comment 3

[Julian Reschke]

Comment on attachment 576723 [details] [diff] [review]
restore previous code, update test cases

(this change is for aurora)

Comment 4

[Julian Reschke]

Attachment: restore previous code, update test cases

patch for mozilla-central (same as aurora)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 576796 [details]
restore previous code, update test cases

r=me

We should probably reopen the bug we're backing out, right?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 576723 [details] [diff] [review]
restore previous code, update test cases

r=me

Comment 7

[Julian Reschke]

(In reply to Boris Zbarsky (:bz) from comment #5)
> We should probably reopen the bug we're backing out, right?

Will do.

Comment 8

[Julian Reschke]

Comment on attachment 576796 [details]
restore previous code, update test cases

Try results: https://tbpl.mozilla.org/?tree=Try&rev=9b8fe5daf2ac

Comment 9

[Andrea]

I confirm that try build https://tbpl.mozilla.org/?tree=Try&rev=9b8fe5daf2ac fixes it.

Comment 10

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/mozilla-central/rev/e7dfdd9a119c

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 576723 [details] [diff] [review]
restore previous code, update test cases

We should take this on beta too.

Comment 12

[Julian Reschke]

(In reply to Boris Zbarsky (:bz) from comment #11)
> Comment on attachment 576723 [details] [diff] [review] [diff] [details] [review]
> restore previous code, update test cases
> 
> We should take this on beta too.

Boris, it's not needed in Beta (these changes appeared in FF10 for the first time). Beta should be fine by now.

Comment 13

[Julian Reschke]

Comment on attachment 576723 [details] [diff] [review]
restore previous code, update test cases

(Removed approval-mozilla-beta request as this shouldn't affect FF9).

Comment 14

[Boris Zbarsky [:bzbarsky]]

> Boris, it's not needed in Beta

Ah, ok.  The tracking flags were just mis-set, arguably, and the status flags not set...

Comment 15

[Alex Keybl [:akeybl]]

Comment on attachment 576723 [details] [diff] [review]
restore previous code, update test cases

[Triage Comment]
Approving for Aurora - sorry about the confusion with FF9 tracking flags.

Comment 16

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d1dd4b71c69e

Comment 17

[Vlad [QA]]

Hi guys.
Can you please tell me how can I test this feature?
Thanks

Comment 18

[Julian Reschke]

(In reply to Vlad [QA] from comment #17)
> Hi guys.
> Can you please tell me how can I test this feature?
> Thanks

You would need an Exchange installation with the current OWA (Outlook Web App) release.

Comment 19

[u279076]

I don't think QA has access to this environment. Julian, would you be willing to verify the fix on Firefox 10?

Comment 20

[Andrea]

I have access to OWA 2010, so I could run some tests. What steps should I follow (test cases to run, fx version to use - is 10b3 ok?)?

Comment 21

[u279076]

Julian can correct me if I am wrong, but I believe the same as you tested in bug 703015 comment 31, Andrea.

Comment 22

[Julian Reschke]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #19)
> I don't think QA has access to this environment. Julian, would you be
> willing to verify the fix on Firefox 10?

I absolutely believe that OWA needs to be something QA can test regularly (I can't).

(In reply to Andrea from comment #20)
> I have access to OWA 2010, so I could run some tests. What steps should I
> follow (test cases to run, fx version to use - is 10b3 ok?)?

The test (and that test should be run for each Firefox release) is whether a download of a mail attachment with non-ASCII characters works properly.

Comment 23

[u279076]

I've started an internal discussion about what QA can do in regards to future OWA testing. Andrea, any help you can provide in regard to this bug specifically would be greatly appreciated.

Comment 24

[Andrea]

Attachment: Fx10beta3: Downloading attachment containing non-ASCII characters in file name

With Fx beta3 (Built from http://hg.mozilla.org/releases/mozilla-beta/rev/e45fb547926c)

Comment 25

[Andrea]

Attachment: Nightly12(x64): Downloading attachment containing non-ASCII characters in file name

Nightly12 (x64) build of 2012-01-10 (Built from http://hg.mozilla.org/mozilla-central/rev/01d69766026d)

Comment 26

[Andrea]

Both download tests succeeded (10 beta3+nightly), file is downloaded with the correct name.

Also test:
http://greenbytes.de/tech/tc2231/#attwithfn2231quot

passed with the same builds of beta3 and nightly (for build info see attachment comments).

Since I have also access to another OWA mailbox that uses an older version (8.3.106.1), I've run the same download tests with the same builds as before and it passed with both of them.

Let me know if there are other tests to be run.