Note: There are a few cases of duplicates in user autocompletion which are being worked on.

add workaround for broken Outlook Web App (OWA) attachment handling

VERIFIED FIXED in Firefox 10

Status

()

Core
Networking
--
major
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Julian Reschke, Assigned: Julian Reschke)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox9+ unaffected, firefox10+ fixed)

Details

(Whiteboard: [qa-], URL)

Attachments

(4 attachments)

(Assignee)

Description

6 years ago
The fix for bug 692574 breaks Exchange 2010'S Outlook Web Access, which apparently sends header in the form:

Content-Disposition:attachment; filename*="Manuale%20installazione%20aggiornamento%20ORACOLO_BATCH%20V1.0.docx"

See also <https://bugzilla.mozilla.org/show_bug.cgi?id=703015#c32>.

We will need to back out the change for bug 692574 for now.
(Assignee)

Updated

6 years ago
Assignee: nobody → julian.reschke
(Assignee)

Updated

6 years ago
Blocks: 609667

Updated

6 years ago
tracking-firefox10: --- → +
tracking-firefox9: --- → +
(Assignee)

Comment 1

6 years ago
The same applies to bug 685192.
(Assignee)

Updated

6 years ago
Summary: add workaround for broken Outlook web access attachment handling → add workaround for broken Outlook Web APP (OWA) attachment handling
(Assignee)

Updated

6 years ago
Summary: add workaround for broken Outlook Web APP (OWA) attachment handling → add workaround for broken Outlook Web App (OWA) attachment handling
(Assignee)

Comment 2

6 years ago
Created attachment 576723 [details] [diff] [review]
restore previous code, update test cases

This reverts the two code changes, but keeps the test cases, noting the changed results.
Attachment #576723 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

6 years ago
Comment on attachment 576723 [details] [diff] [review]
restore previous code, update test cases

(this change is for aurora)
(Assignee)

Comment 4

6 years ago
Created attachment 576796 [details]
restore previous code, update test cases

patch for mozilla-central (same as aurora)
Attachment #576796 - Flags: review?(bzbarsky)

Updated

6 years ago
Blocks: 692574

Comment 5

6 years ago
Comment on attachment 576796 [details]
restore previous code, update test cases

r=me

We should probably reopen the bug we're backing out, right?
Attachment #576796 - Flags: review?(bzbarsky) → review+

Comment 6

6 years ago
Comment on attachment 576723 [details] [diff] [review]
restore previous code, update test cases

r=me
Attachment #576723 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

6 years ago
Attachment #576723 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

6 years ago
Attachment #576796 - Flags: checkin?
(Assignee)

Comment 7

6 years ago
(In reply to Boris Zbarsky (:bz) from comment #5)
> We should probably reopen the bug we're backing out, right?

Will do.
(Assignee)

Comment 8

6 years ago
Comment on attachment 576796 [details]
restore previous code, update test cases

Try results: https://tbpl.mozilla.org/?tree=Try&rev=9b8fe5daf2ac

Comment 9

6 years ago
I confirm that try build https://tbpl.mozilla.org/?tree=Try&rev=9b8fe5daf2ac fixes it.

Comment 10

6 years ago
http://hg.mozilla.org/mozilla-central/rev/e7dfdd9a119c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 11

6 years ago
Comment on attachment 576723 [details] [diff] [review]
restore previous code, update test cases

We should take this on beta too.
Attachment #576723 - Flags: approval-mozilla-beta?

Updated

6 years ago
Attachment #576796 - Flags: checkin? → checkin+
(Assignee)

Comment 12

6 years ago
(In reply to Boris Zbarsky (:bz) from comment #11)
> Comment on attachment 576723 [details] [diff] [review] [diff] [details] [review]
> restore previous code, update test cases
> 
> We should take this on beta too.

Boris, it's not needed in Beta (these changes appeared in FF10 for the first time). Beta should be fine by now.
(Assignee)

Comment 13

6 years ago
Comment on attachment 576723 [details] [diff] [review]
restore previous code, update test cases

(Removed approval-mozilla-beta request as this shouldn't affect FF9).
Attachment #576723 - Flags: approval-mozilla-beta?

Comment 14

6 years ago
> Boris, it's not needed in Beta

Ah, ok.  The tracking flags were just mis-set, arguably, and the status flags not set...
status-firefox10: --- → affected
status-firefox9: --- → unaffected
Comment on attachment 576723 [details] [diff] [review]
restore previous code, update test cases

[Triage Comment]
Approving for Aurora - sorry about the confusion with FF9 tracking flags.
Attachment #576723 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Updated

6 years ago
Attachment #576723 - Flags: checkin?

Updated

6 years ago
Keywords: checkin-needed

Comment 16

6 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/d1dd4b71c69e
status-firefox10: affected → fixed
Keywords: checkin-needed
Target Milestone: --- → mozilla11

Updated

6 years ago
Attachment #576723 - Flags: checkin? → checkin+
Whiteboard: [qa+]

Comment 17

6 years ago
Hi guys.
Can you please tell me how can I test this feature?
Thanks
(Assignee)

Comment 18

6 years ago
(In reply to Vlad [QA] from comment #17)
> Hi guys.
> Can you please tell me how can I test this feature?
> Thanks

You would need an Exchange installation with the current OWA (Outlook Web App) release.
I don't think QA has access to this environment. Julian, would you be willing to verify the fix on Firefox 10?
Whiteboard: [qa+] → [qa-]

Comment 20

6 years ago
I have access to OWA 2010, so I could run some tests. What steps should I follow (test cases to run, fx version to use - is 10b3 ok?)?
Julian can correct me if I am wrong, but I believe the same as you tested in bug 703015 comment 31, Andrea.
(Assignee)

Comment 22

6 years ago
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #19)
> I don't think QA has access to this environment. Julian, would you be
> willing to verify the fix on Firefox 10?

I absolutely believe that OWA needs to be something QA can test regularly (I can't).

(In reply to Andrea from comment #20)
> I have access to OWA 2010, so I could run some tests. What steps should I
> follow (test cases to run, fx version to use - is 10b3 ok?)?

The test (and that test should be run for each Firefox release) is whether a download of a mail attachment with non-ASCII characters works properly.
I've started an internal discussion about what QA can do in regards to future OWA testing. Andrea, any help you can provide in regard to this bug specifically would be greatly appreciated.

Comment 24

6 years ago
Created attachment 587625 [details]
Fx10beta3: Downloading attachment containing non-ASCII characters in file name

With Fx beta3 (Built from http://hg.mozilla.org/releases/mozilla-beta/rev/e45fb547926c)

Comment 25

6 years ago
Created attachment 587626 [details]
Nightly12(x64): Downloading attachment containing non-ASCII characters in file name

Nightly12 (x64) build of 2012-01-10 (Built from http://hg.mozilla.org/mozilla-central/rev/01d69766026d)

Comment 26

6 years ago
Both download tests succeeded (10 beta3+nightly), file is downloaded with the correct name.

Also test:
http://greenbytes.de/tech/tc2231/#attwithfn2231quot

passed with the same builds of beta3 and nightly (for build info see attachment comments).

Since I have also access to another OWA mailbox that uses an older version (8.3.106.1), I've run the same download tests with the same builds as before and it passed with both of them.

Let me know if there are other tests to be run.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.