70500 - Crash in opening mail compose window

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Tracy Walker [:tracy]]

seen on commercial build 2001-02-28-11-mtrunk

-open mail
-reply to a message or make a new message

the compose window opens, then the app crashes

reproduceable everytime

Comment 1

[laurel]

Doesn't crash for me using same build, win98. Tried new and existing profiles,
IMAP and POP, HTML and plain text compose windows, New msg and reply.

I did not remove registry and start fresh, though.

Comment 2

[Jean-Francois Ducarroz]

jgmyers, any idea?

Comment 3

[J.J. Enser]

cc'ing pchen, sheriff of the day

Comment 4

[Jean-Francois Ducarroz]

can we get a stack trace?

Comment 5

[John G. Myers]

Likely a dup of 70505.

Comment 6

[Jean-Francois Ducarroz]

are you sure you are crashing doing a new message!

Comment 7

[J.J. Enser]

Tracy is gone fo the day. Marking dup of 70505. He will reopen this one tomorrow 
if it turns out to be a different issue

*** This bug has been marked as a duplicate of 70505 ***

Comment 8

[Tracy Walker [:tracy]]

verifed dupe

Comment 9

[Tracy Walker [:tracy]]

whoa! taking two steps back... reopening...

bug 70505 was for linux...which is fixed...this bug is for windows which is 
still crashing when attempting to compose a mail message

seeing on commercial build 2001-03-01-11-mtrunk

Comment 10

[Tracy Walker [:tracy]]

marking wfm....this was isolated to my system
profile was corrupted...using a new profile alleviated the problem

Comment 11

[Jean-Francois Ducarroz]

Varada and I found the problem, we will attach soon a 1 line fix. What append is 
that the mail account is setup for attaching the signature to news messages but 
the pref that contains the signature file path is invalid.

Comment 12

[Jean-Francois Ducarroz]

here is the fix:

Index: mozilla/mailnews/compose/src/nsMsgCompose.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/compose/src/nsMsgCompose.cpp,v
retrieving revision 1.234
diff -w -b -u -2 -r1.234 nsMsgCompose.cpp
--- nsMsgCompose.cpp	2001/02/26 20:39:09	1.234
+++ nsMsgCompose.cpp	2001/03/01 23:23:18
@@ -1941,6 +1941,8 @@
       nsCOMPtr<nsILocalFile> sigFile;
       rv = identity->GetSignature(getter_AddRefs(sigFile));
-      if (NS_SUCCEEDED(rv))
+      if (NS_SUCCEEDED(rv) && sigFile)
         rv = sigFile->GetPath(getter_Copies(sigNativePath));
+      else
+        useSigFile = PR_FALSE;  //No signature file! therefore turn it off.
     }
   }

Comment 13

[Jean-Francois Ducarroz]

R=varada

Comment 14

[Jean-Francois Ducarroz]

I just discovered that at least on Mac, the signature patch you set throough the
account setting doesn't stick anymore. I'll file a new bug for that.

Comment 15

[esther]

Using commercial build 2001-03-01 on winme, linux and mac this doesn't crash for
me using html or plain text on pop or imap. I was just about to verify this, but
now you have a fix.  Can you put additional steps in this bug that cause the crash.

Comment 16

[lpham]

Tracy confirmed with me this bug is invalid.
Loan

Comment 17

[Jean-Francois Ducarroz]

Fixed and checked in.

Comment 18

[Jean-Francois Ducarroz]

is not an invalid bug, the corrupction Travy get is apparently due to the fix 
for bug 41083. This could affect other people as well.

Comment 19

[David :Bienvenu]

sr=bienvenu, FWIW

Comment 20

[lpham]

Does this bug already fix?  

Comment 21

[Jean-Francois Ducarroz]

Yes

Comment 22

[Tracy Walker [:tracy]]

verified windows commercial build 2001-03-02-06-mtrunk

Comment 23

[Matthias Versen [:Matti]]

repairing bugzilla problem (current bug state: Status:Verified, Resolution:) 

Comment 24

[Matthias Versen [:Matti]]

fixed

Comment 25

[Matthias Versen [:Matti]]

verified fixed