Closed
Bug 705020
Opened 10 years ago
Closed 8 years ago
remove enable-js-diagnostics flag from nightly mozconfig
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox20 fixed, firefox21 fixed)
RESOLVED
FIXED
Firefox 21
People
(Reporter: dougt, Assigned: kats)
Details
Attachments
(2 files)
851 bytes,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
886 bytes,
patch
|
dougt
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
From email: me: we are building with --enable-js-diagnostics in our nightly builds. anyone know what this means w.r.t perf? Also, if this is a high cost, do we know the value? David Mandelin: I don't think it's too expensive. But I also doubt it would really be useful to you--that stuff was for trying to diagnose GC crashes, and mostly it just told us that all of our actionable ideas about what was causing crashes weren't right.
Reporter | ||
Comment 1•10 years ago
|
||
Assignee: nobody → doug.turner
Attachment #576657 -
Flags: review?(mbrubeck)
Updated•10 years ago
|
Attachment #576657 -
Flags: review?(mbrubeck) → review+
Reporter | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/9d869fde41b8
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•8 years ago
|
||
This option still exists in the mobile/xul nightly mozconfig, and should probably be removed there. The reason I care is because it is now in the mozilla-aurora tree as well, http://hg.mozilla.org/releases/mozilla-aurora/file/489f8fb0b4fa/mobile/xul/config/mozconfigs/android/nightly even though it's explicitly supposed to only be on nightlies. Clearly something went wrong.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #699203 -
Flags: review?(doug.turner)
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 699203 [details] [diff] [review] Remove from mobile/xul [Approval Request Comment] Bug caused by (feature/regressing bug #): version bump when aurora went from 19 -> 20 User impact if declined: in theory, aurora builds from XUL fennec will have some js diagnostic stuff turned on, but i don't think anybody is building that so it doesn't really matter. this does show up when i diff the FF19 tree at the end of aurora and the start of beta so that's kind of annoying Testing completed (on m-c, etc.): none Risk to taking this patch (and alternatives if risky): should be no risk, this isn't even being used anywhere really String or UUID changes made by this patch: none
Attachment #699203 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 6•8 years ago
|
||
Actually, sorry, it's unrelated to the 19 -> 20 version bump, I misread the hg history. It's been on aurora for a long time.
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 699203 [details] [diff] [review] Remove from mobile/xul Review of attachment 699203 [details] [diff] [review]: ----------------------------------------------------------------- i do not care about mobile/xul, but the patch lgtm. i'd love to r+ a patch that removed mobile/xul from m-c.
Attachment #699203 -
Flags: review?(doug.turner) → review+
Assignee | ||
Comment 8•8 years ago
|
||
I'm sure that'll come too in time :) https://hg.mozilla.org/integration/mozilla-inbound/rev/d326a33ad6f6
Comment 9•8 years ago
|
||
This was NPOTB - for future patches like this, please can you use DONTBUILD :-)
Comment 10•8 years ago
|
||
(d326a33ad6f6 that is)
Reporter | ||
Updated•8 years ago
|
Assignee: doug.turner → bugmail.mozilla
Comment 11•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d326a33ad6f6
Status: REOPENED → RESOLVED
Closed: 10 years ago → 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Updated•8 years ago
|
Attachment #699203 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 12•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/ba542f60722b
status-firefox20:
--- → fixed
status-firefox21:
--- → fixed
Updated•4 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•