GLContext->Layers code doesn't properly guarantee that it resolves the GLContext before using its contents

RESOLVED FIXED in mozilla11

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We need to first guarantee we are correctly resolving buffers before we use their contents. We need to do this properly before we try to do it quickly.
(Assignee)

Updated

6 years ago
Blocks: 701269
(Assignee)

Comment 1

6 years ago
Created attachment 579813 [details] [diff] [review]
Add flexible function for ordering resolves
Attachment #579813 - Flags: review?(bjacob)
Comment on attachment 579813 [details] [diff] [review]
Add flexible function for ordering resolves

Review of attachment 579813 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the following naming nit:

::: gfx/gl/GLContext.h
@@ +758,5 @@
> +protected:
> +    bool mFlushGuaranteesResolve;
> +
> +public:
> +    void FlushGuaranteesResolve(bool aFlushGuaranteesResolve) {

I would rename this to SetFlushGuaranteesResolve.
Attachment #579813 - Flags: review?(bjacob) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ba4a7f652fb

Your nit is included.
Target Milestone: --- → mozilla11
(Assignee)

Updated

6 years ago
Blocks: 711649
https://hg.mozilla.org/mozilla-central/rev/9ba4a7f652fb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 727178
You need to log in before you can comment on or make changes to this bug.