Closed Bug 705024 Opened 9 years ago Closed 9 years ago

GLContext->Layers code doesn't properly guarantee that it resolves the GLContext before using its contents

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file)

We need to first guarantee we are correctly resolving buffers before we use their contents. We need to do this properly before we try to do it quickly.
Blocks: 701269
Comment on attachment 579813 [details] [diff] [review]
Add flexible function for ordering resolves

Review of attachment 579813 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the following naming nit:

::: gfx/gl/GLContext.h
@@ +758,5 @@
> +protected:
> +    bool mFlushGuaranteesResolve;
> +
> +public:
> +    void FlushGuaranteesResolve(bool aFlushGuaranteesResolve) {

I would rename this to SetFlushGuaranteesResolve.
Attachment #579813 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ba4a7f652fb

Your nit is included.
Target Milestone: --- → mozilla11
Blocks: 711649
https://hg.mozilla.org/mozilla-central/rev/9ba4a7f652fb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 727178
You need to log in before you can comment on or make changes to this bug.