705024 - GLContext->Layers code doesn't properly guarantee that it resolves the GLContext before using its contents

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

We need to first guarantee we are correctly resolving buffers before we use their contents. We need to do this properly before we try to do it quickly.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Add flexible function for ordering resolves

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 579813 [details] [diff] [review]
Add flexible function for ordering resolves

Review of attachment 579813 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the following naming nit:

::: gfx/gl/GLContext.h
@@ +758,5 @@
> +protected:
> +    bool mFlushGuaranteesResolve;
> +
> +public:
> +    void FlushGuaranteesResolve(bool aFlushGuaranteesResolve) {

I would rename this to SetFlushGuaranteesResolve.

Comment 3

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ba4a7f652fb

Your nit is included.

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/9ba4a7f652fb