Last Comment Bug 705024 - GLContext->Layers code doesn't properly guarantee that it resolves the GLContext before using its contents
: GLContext->Layers code doesn't properly guarantee that it resolves the GLCont...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla11
Assigned To: Jeff Gilbert [:jgilbert]
:
Mentors:
Depends on: 727178
Blocks: 697831 701269 711649
  Show dependency treegraph
 
Reported: 2011-11-23 17:21 PST by Jeff Gilbert [:jgilbert]
Modified: 2012-02-14 11:35 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add flexible function for ordering resolves (3.98 KB, patch)
2011-12-07 13:18 PST, Jeff Gilbert [:jgilbert]
jacob.benoit.1: review+
Details | Diff | Splinter Review

Description Jeff Gilbert [:jgilbert] 2011-11-23 17:21:35 PST
We need to first guarantee we are correctly resolving buffers before we use their contents. We need to do this properly before we try to do it quickly.
Comment 1 Jeff Gilbert [:jgilbert] 2011-12-07 13:18:49 PST
Created attachment 579813 [details] [diff] [review]
Add flexible function for ordering resolves
Comment 2 Benoit Jacob [:bjacob] (mostly away) 2011-12-13 10:45:21 PST
Comment on attachment 579813 [details] [diff] [review]
Add flexible function for ordering resolves

Review of attachment 579813 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the following naming nit:

::: gfx/gl/GLContext.h
@@ +758,5 @@
> +protected:
> +    bool mFlushGuaranteesResolve;
> +
> +public:
> +    void FlushGuaranteesResolve(bool aFlushGuaranteesResolve) {

I would rename this to SetFlushGuaranteesResolve.
Comment 3 Jeff Gilbert [:jgilbert] 2011-12-16 14:30:35 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ba4a7f652fb

Your nit is included.
Comment 4 Matt Brubeck (:mbrubeck) 2011-12-17 09:29:02 PST
https://hg.mozilla.org/mozilla-central/rev/9ba4a7f652fb

Note You need to log in before you can comment on or make changes to this bug.