705040 - buildbot copy-mozconfig logic needs to be in a WithProperties

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P5)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

we recently split android into android-xul and android (native).  I want to push a patch from birch to try and get test results.  I have options in try chooser for 'android' and 'android-xul', but I cannot build opt for 'android', only 'debug'.

debug tests don't seem to be an option on android.

Here is a link to my most recent push.

https://tbpl.mozilla.org/?tree=Try&rev=29cafe2279e2&pusher=[e-mail]&noignore=1

Please let me know what I need to do in order to get a patch pushed so I can run the tests which are run on Birch.

Comment 1

[Phil Ringnalda (:philor)]

I usually pick the wrong place in buildbot's tangle, but I think what you would need to do - obviously, not in a push to try ;) - is stick a

'platforms': {
  'android': {},
},

into http://hg.mozilla.org/build/buildbot-configs/file/4e3386c90964/mozilla/config.py#l1105 because bug 704200 killed it for everything which doesn't explicitly set that platform, which is everything-including-try, other than birch.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

So I have been trying since Wednesday morning to test my patch on try server and I have had no luck.  Can we make this a higher priority?

Comment 3

[Aki Sasaki (not active)]

This won't work until we patch this (bug 704200 killed try 'android' support) and reconfig, so you can stop trying.
Sorry about that.
Aiui, we're planning on merging birch to m-c on Tuesday, so it'll start working then if nothing else happens here.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

A workaround is to do this:
https://hg.mozilla.org/try/rev/471ca5570cfe
(which is the result of copying mobile/android/config/mozconfigs/nightly to mobile/xul/config/mozconfigs/nightly).

(I wonder whether all the differences between those files were intentional, though.)

Comment 6

[Aki Sasaki (not active)]

Attachment: turn try android platform back on

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 577324 [details] [diff] [review]
turn try android platform back on

http://hg.mozilla.org/build/buildbot-configs/rev/ea0abf7f4144
Should hopefully go live today.

Comment 8

[Aki Sasaki (not active)]

This should be fixed now.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

I am unable to get tests to run via a standard push to try.  I use this try syntax:
try: -b do -p android,android-xul -u reftest-1,reftest-2,reftest-3,jsreftest-1,jsreftest-2,jsreftest-3,crashtest-1,crashtest-2,crashtest-3 -t none

and get this result:
https://tbpl.mozilla.org/?tree=Try&rev=0ff7b4909bb5

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

can we get some resolution on this issue?

Comment 11

[Aki Sasaki (not active)]

Two issues:

1. it didn't find the existing in-tree mozconfig. https://hg.mozilla.org/try/file/0ff7b4909bb5/mobile/android/config/mozconfigs/android/nightly
2. it hit a syntax error trying to wget the mozconfig (not replacing %(branch)s I think)


python /builds/slave/try-andrd/tools/buildfarm/utils/retry.py -s 1 -r 5 -t 1260 bash -c 'if [ -f "mobile/android/config/mozconfigs/android/nightly" ]; then                        echo Using in-tree mozconfig;                        cp mobile/android/config/mozconfigs/android/nightly .mozconfig;                    else                        echo Downloading mozconfig;                        wget -O .mozconfig http://hg.mozilla.org/build/buildbot-configs/raw-file/production/mozilla2/android/%(branch)s/nightly/mozconfig;                    fi'
 in dir /builds/slave/try-andrd/build (timeout 1320 secs)

Calling <function run_with_timeout at 0xb7c7502c> with args: (['bash', '-c', 'if [ -f "mobile/android/config/mozconfigs/android/nightly" ]; then                        echo Using in-tree mozconfig;                        cp mobile/android/config/mozconfigs/android/nightly .mozconfig;                    else                        echo Downloading mozconfig;                        wget -O .mozconfig http://hg.mozilla.org/build/buildbot-configs/raw-file/production/mozilla2/android/%(branch)s/nightly/mozconfig;                    fi'], 1260, None, None, False, True), kwargs: {}, attempt #1
Executing: ['bash', '-c', 'if [ -f "mobile/android/config/mozconfigs/android/nightly" ]; then                        echo Using in-tree mozconfig;                        cp mobile/android/config/mozconfigs/android/nightly .mozconfig;                    else                        echo Downloading mozconfig;                        wget -O .mozconfig http://hg.mozilla.org/build/buildbot-configs/raw-file/production/mozilla2/android/%(branch)s/nightly/mozconfig;                    fi']
bash: -c: line 0: syntax error near unexpected token `('

Comment 12

[Aki Sasaki (not active)]

Attachment: WithProperties fix ?

Comment 13

[Chris AtLee [:catlee]]

Comment on attachment 579540 [details] [diff] [review]
WithProperties fix ?

Review of attachment 579540 [details] [diff] [review]:
-----------------------------------------------------------------

::: process/factory.py
@@ +1092,5 @@
>          assert self.mozconfig is not None
>  
>          configRepo = self.getRepository(self.configRepoPath)
> +        hg_mozconfig = WithProperties('%s/raw-file/%s/%s/%s/mozconfig' % (
> +                configRepo, self.mozconfigBranch, self.configSubDir, self.mozconfig))

I don't think this will work. You'll end up with 

"bash -c .... wget -O .mozconfig <WithProperties instance at 0x123456>" as your command.

Wrapping the last part of bash command in WithProperties should work, but you need to be careful about which %'s get expanded.

Comment 14

[Aki Sasaki (not active)]

Attachment: [needs testing?] WithProperties fix take 2

Comment 15

[Aki Sasaki (not active)]

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&jobname=Android&noignore=1&pusher=[e-mail]

Now that native has landed on m-c, is this better?
The above tbpl link seems to show that android native works on try now.

Comment 17

[Aki Sasaki (not active)]

Joel is now able to get android builds and tests on Try.
Attachment 579833 [details] [diff] can still fix the underlying issue with the bash command, but we shouldn't hit it in this instance anymore, so I'm lowering priority.
Keeping open for when someone has spare time to test+land it, or if this resurfaces.

Comment 18

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Found in triage.

Comment 19

[[e-mail] (:bhearsum)]

Probably never going to fix this since we're moving to Taskcluster.