Closed Bug 705046 Opened 13 years ago Closed 11 years ago

test_html5_tree_construction_part2.html fails on Mac OS X 10.7 (Lion) and 10.8 (Mountain Lion)

Categories

(Core :: DOM: HTML Parser, defect)

Product:
Core
Component:
DOM: HTML Parser
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: dbaron, Assigned: wchen)

References

Details

(Whiteboard: [qa-])

Attachments

(3 files)

disable two hunks
2.41 KB, patch
hsivonen
: review+
Details | Diff | Splinter Review
on 10.8 too
1.09 KB, patch
philor
: checkin+
Details | Diff | Splinter Review
Enable html5 tests on mac
2.43 KB, patch
hsivonen
: review+
Details | Diff | Splinter Review 
There are now unit tests running on Mac OS X 10.7, some of which are hidden.  Every mochitest-5 run is failing with:

823 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_html5_tree_construction_part2.html | HTML5 expected success. - got | <!DOCTYPE html>
824 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_html5_tree_construction_part2.html | [SimpleTest/SimpleTest.js, window.onerror] - An error occurred: createTextNode is not defined at http://mochi.test:8888/tests/parser/htmlparser/tests/mochitest/parser_web_testrunner.js:77

For logs, see: https://tbpl.mozilla.org/?noignore=1
The createTextNode part is particularly strange. There are indeed calls to createTextNode without qualifying them with document., but why does this work on other platforms?
Be nice if there was a little more granularity about disabling a particular test on a particular platform, but look at it this way: you aren't losing two whole .dat files, because right now with them hidden you have zero; instead you are gaining all but these two. The <applet>s in tests19.dat and tests7.dat are apparently the only things that touches our broken plugin code in mochitest-5, so this lets us unhide both opt and debug - https://tbpl.mozilla.org/?tree=Try&noignore=1&rev=908b750b345d
Attachment #625502 - Flags: review?(hsivonen)
Comment on attachment 625502 [details] [diff] [review]
disable two hunks

I guess this is better than the alternatives for now, but it would be nice to understand the true nature of the failure eventually.
Attachment #625502 - Flags: review?(hsivonen) → review+
No longer blocks: 700503
Blocks: 786084
Summary: test_html5_tree_construction_part2.html fails on Mac OS X 10.7 (Lion) → test_html5_tree_construction_part2.html fails on Mac OS X 10.7 (Lion) and 10.8 (Mountain Lion)
https://hg.mozilla.org/mozilla-central/rev/a4977a26f99d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Those tests no longer fail on mac anymore:

https://tbpl.mozilla.org/?tree=Try&rev=06bdd6f9920e

At this point, I don't think it's worth investigating what made those tests fail two years ago. Since I can no longer see the original failures, I'm going to guess that some broken plugin code was fixed some time in the past (based on comment 2).
Attachment #831687 - Flags: review?(hsivonen)
Attachment #831687 - Flags: review?(hsivonen) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b4ceac5a7f9
Assignee: nobody → wchen
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86_64 → All
Whiteboard: [leave open][qa-] → [qa-]
OS: All → Mac OS X
https://hg.mozilla.org/mozilla-central/rev/0b4ceac5a7f9
Status: REOPENED → RESOLVED
Closed: 12 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: