705051 - enter_bug.cgi should say if a product is visible only to people with permissions

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, enhancement)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://bugzilla.mozilla.org/enter_bug.cgi?full=1 lists the products available to the bug reporter.  However, sometimes the bug reporter can see products that others can't.  But this can lead to confusion when talking about how to file a bug.  See, for example: https://groups.google.com/group/mozilla.governance/msg/b368329baf156921

For example, one of the products in b.m.o, "Mozilla Corporation" (which is for filing bugs on the office, like if there's a problem with the plumbing), is visible only to people who have the MoCo-employee permission bit set on their account.

To avoid this, enter_bug.cgi should have text (and probably also a different background color) next to a product that's only visible to some users saying who it's visible to.

Comment 1

[Max Kanat-Alexander]

Probably just displaying the lock icon would do.

Comment 2

[timeless]

Some bugzillas restrict all products.

You might get away with a lock icon on bmo, but it's useless and won't help anyone.

The question someone needs to answer is "what group do I need to be in to use this product/component?"

Comment 3

[Gervase Markham [:gerv]]

The Bugzillas which restrict all products are being used in a different way to public Bugzillas which have some restrictions. There are various places where the best UI for the two has to differ, and this is one of them. 

It's fine for the actual UI for this to be a bmo-only change, although the infrastructure (e.g. CSS classes) to support it should be upstreamed.

Each "row" should have a CSS class "group" if it's in any group, and then "group-N" for each group you need to be/can be in.

Gerv

Comment 4

[Max Kanat-Alexander]

I'm fine with a lock icon for now. We already have it and it will be easy to implement.

Comment 5

[Gervase Markham [:gerv]]

Attachment: Patch v.0.5

WIP patch. But I can't quite figure out how to ask a Product object for a list of all the groups you need to enter a bug into it... dkl, any ideas?

Gerv

Comment 6

[David Lawrence [:dkl]]

Attachment: Patch to add secure group class to products requiring group membership (v1)

You can use Bugzilla::Product::group_controls to get the information you need. I have created a patch that shows how to use it in enter_bug.cgi. Just need the related CSS changes to display the secure icon.

dkl

Comment 7

[Gervase Markham [:gerv]]

Attachment: Patch v.2

dkl: Great! One issue: this patch leaks group names; I believe we have a policy of not leaking group names to people not in the relevant group? Replace ".name" with ".id" and it should be OK.

Updated patch attached with CSS - is it in the right place?

Gerv

Comment 8

[David Lawrence [:dkl]]

Lets do this. Since this is patching file(s) that are part of the BMO extension for now, we will track this as a BMO customization. The once complete, Gerv can work up a patch that works with the upstream code and create a new bug for review separate from this one.

dkl

Comment 9

[David Lawrence [:dkl]]

Comment on attachment 581955 [details] [diff] [review]
Patch v.2

Review of attachment 581955 [details] [diff] [review]:
-----------------------------------------------------------------

I would move the change in skins/standard/global.css to skins/custom/global.css since this will initially be a BMO only change. Later
if accepted upstream it will go into skins/standard/global.css.

Also I would add a title= attribute to the <a> product link and/or the icon image stating that the product is protected by one or more permission groups
just for further clarity if entry_groups.size > 0.

dkl

::: skins/standard/global.css
@@ +575,5 @@
>  #down_button {
>      background-image: url(global/down.png);
>  }
> +
> +.group_secure > th {

Currently the lock shows up on the far left of the window on the same row as the product leaving a gap. I feel it would be less confusing if the icon was right next to the link itself. So changing to:

.group_secure > th > a {

accomplishes that.

Comment 10

[Gervase Markham [:gerv]]

Attachment: Patch v.3

Comment 11

[David Lawrence [:dkl]]

Attachment: Patch (dkl)

Look at this more, I think this patch simplifies it and also cuts out an extra loop. Your patch is fine too but let me know if you think this way is better.

dkl

Comment 12

[Gervase Markham [:gerv]]

Comment on attachment 582381 [details] [diff] [review]
Patch (dkl)

Yep; I must have lost the wood in the trees. Seems fine.

Gerv

Comment 13

[David Lawrence [:dkl]]

Thanks gerv

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified extensions/BMO/template/en/default/global/choose-product.html.tmpl
modified skins/custom/global.css                                                                                 Committed revision 7987

dkl