Closed
Bug 705104
Opened 14 years ago
Closed 14 years ago
Handle permission errors in indextree
Categories
(Webtools Graveyard :: DXR, defect, P3)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: christian, Assigned: christian)
Details
Attachments
(1 file, 1 obsolete file)
|
1.37 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
The try/except blocks expect that files may not have existed before, so ignoring errors removing old files is right. But if, for whatever reason, permissions on one of the files are wrong, the function breaks silently and leads to confusing "file exists" errors later on.
|
Assignee | |
Comment 1•14 years ago
|
||
Testing the error string was the most elegant way I found as there's no distinct error type for permission issues.
Attachment #576725 -
Flags: review?(Pidgeot18)
|
|
Assignee | |
Updated•14 years ago
|
OS: Mac OS X → Linux
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → christian.dywan
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 576725 [details] [diff] [review]
Handle permission errors in indextree
a helper like assert_permission_denied(sys.exc_info()) would be nicer
Attachment #576725 -
Flags: review?(Pidgeot18) → review-
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #576725 -
Attachment is obsolete: true
Attachment #577596 -
Flags: review?(Pidgeot18)
|
||
Comment 4•14 years ago
|
||
Comment on attachment 577596 [details] [diff] [review]
Handle permission errors in indextree #2
This is going to cause the same error message to be printed for any type of permission error no matter where the error happens, right?
Attachment #577596 -
Flags: review?(Pidgeot18) → review-
|
|
Assignee | |
Comment 5•14 years ago
|
||
No, the original error is printed verbatim.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #577596 -
Flags: review- → review?(Pidgeot18)
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•14 years ago
|
Attachment #577596 -
Flags: review?(Pidgeot18) → review?(ehsan)
|
|
||
Updated•14 years ago
|
Attachment #577596 -
Flags: review?(ehsan) → review+
|
|
||
Comment 6•14 years ago
|
||
I cannot reproduce that one.
If you can reproduce it, please reopen the bug and tell me the steps.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Priority: -- → P3
Resolution: --- → WORKSFORME
|
||
Updated•5 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•