This code brings Qt-Mozilla up to basic functionality, including basic support for Clipboard, Drag and Drop and CSS-2 Font Selection. The attached tarball contains new code for the mozilla/widget/src/qt, mozilla/widget/timer/src/unix/qt and mozilla/gfx/src/qt directories. In addition to replacements for files already in Mozilla.org CVS, the following new files are included: widget/src/qt/nsMime.cpp widget/src/qt/nsMime.h widget/src/qt/nsQWidget.cpp widget/src/qt/nsQWidget.h widget/src/qt/nsIDragSessionQt.h These files must be added to Mozilla.org CVS.
John, what version of qt is required for these changes to work? I applied the configure.in patch and ran autoconf but I'm still seeing strcmp being redefined to qstrcmp. I'm using the 2.1.0-4.beta1 rpms from RH 6.2.
Hmm. I've been building using Qt 2.2.x (recently 2.2.4, but I've used pretty much every version since 2.2.1 without this problem). The thing to look for is "-DQT_GENUINE_STR" in the QT_CFLAGS macro - this is what turns off Qt's penchant for replacing all of the str... functions with its own qstr... versions. What file are you seeing the problem in?
I found another problem - the GetBuffer -> get change in nsAutoString that landed this weekend breaks gfx/src/qt/nsFontMetricsQT.cpp. I can post a patch, but the manual work-around is pretty simple - just search gfx/src/qt/nsFontMetricsQT.cpp for GetBuffer and replace all instances with get. If a patch is required, I'll need some guidance on how to generate it, since I can't diff against CVS (which still has older code).
i guess this is considered ports so you probably only need review...
Oops, forgot to cc myself to the bug. I don't remember which file I was seeing the problem in. After upgrading my box to qt 2.2.4, the latest tarball compiles with some minor tweaks. My initial -O3 build failed to run but my debug build appears to work so I could've hit yet another compiler optimization bug. r=cls Do you have a cvs acct to check these changes in or do you need some else to check these changes in for you?
Code has been checked into Mozilla.org CVS (finally!)
Spam: what is "QT"? where is the info on it?
QT is the toolkit used in KDE. http://www.kde.org . And http://www.trolltech.no for more info on QT itself. Gerv
vrfy code is in cvs and compiles