Last Comment Bug 70511 - Basic Code for Qt-Mozilla
: Basic Code for Qt-Mozilla
Product: Core
Classification: Components
Component: XUL (show other bugs)
: Trunk
: x86 Linux
-- normal (vote)
: ---
Assigned To: John Griggs
: John Morrison
: Neil Deakin
Depends on: 70509
  Show dependency treegraph
Reported: 2001-02-28 14:40 PST by John Griggs
Modified: 2001-04-24 02:03 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

tar ball of source for Qt-Mozilla port (72.80 KB, application/octet-stream)
2001-02-28 14:41 PST, John Griggs
no flags Details
tarball of new Qt Mozilla source (95.41 KB, application/octet-stream)
2001-03-29 11:22 PST, John Griggs
no flags Details

Description User image John Griggs 2001-02-28 14:40:11 PST
This code brings Qt-Mozilla up to basic functionality, including basic support
for Clipboard, Drag and Drop and CSS-2 Font Selection.

The attached tarball contains new code for the mozilla/widget/src/qt,
mozilla/widget/timer/src/unix/qt and mozilla/gfx/src/qt directories.  In
addition to replacements for files already in CVS, the following new
files are included:


These files must be added to CVS.
Comment 1 User image John Griggs 2001-02-28 14:41:23 PST
Created attachment 26450 [details]
tar ball of source for Qt-Mozilla port
Comment 2 User image cls 2001-03-03 16:11:08 PST
John,  what version of qt is required for these changes to work?  I applied the patch and ran autoconf but I'm still seeing strcmp being redefined
to qstrcmp.  I'm using the 2.1.0-4.beta1 rpms from RH 6.2. 
Comment 3 User image John Griggs 2001-03-05 06:40:53 PST
Hmm.  I've been building using Qt 2.2.x (recently 2.2.4, but I've used pretty
much every version since 2.2.1 without this problem).  The thing to look for is
"-DQT_GENUINE_STR" in the QT_CFLAGS macro - this is what turns off Qt's penchant
for replacing all of the str... functions with its own qstr... versions.  What
file are you seeing the problem in?
Comment 4 User image John Griggs 2001-03-05 07:05:11 PST
I found another problem - the GetBuffer -> get change in nsAutoString that
landed this weekend breaks gfx/src/qt/nsFontMetricsQT.cpp.  I can post a patch,
but the manual work-around is pretty simple - just search
gfx/src/qt/nsFontMetricsQT.cpp for GetBuffer and replace all instances with get.

If a patch is required, I'll need some guidance on how to generate it, since I
can't diff against CVS (which still has older code).
Comment 5 User image timeless 2001-03-05 08:42:31 PST
i guess this is considered ports so you probably only need review...
Comment 6 User image John Griggs 2001-03-29 11:22:56 PST
Created attachment 29148 [details]
tarball of new Qt Mozilla source
Comment 7 User image cls 2001-03-31 06:27:40 PST
Oops, forgot to cc myself to the bug.  I don't remember which file I was seeing
the problem in.  After upgrading my box to qt 2.2.4, the latest tarball compiles
with some minor tweaks.  My initial -O3 build failed to run but my debug build
appears to work so I could've hit yet another compiler optimization bug. r=cls

Do you have a cvs acct to check these changes in or do you need some else to
check these changes in for you?
Comment 8 User image John Griggs 2001-04-06 12:19:48 PDT
Code has been checked into CVS (finally!)
Comment 9 User image Peter Lairo 2001-04-10 00:36:20 PDT
Spam: what is "QT"? where is the info on it?
Comment 10 User image Gervase Markham [:gerv] 2001-04-10 01:37:37 PDT
QT is the toolkit used in KDE. . And
for more info on QT itself.

Comment 11 User image timeless 2001-04-24 02:03:52 PDT
vrfy code is in cvs and compiles

Note You need to log in before you can comment on or make changes to this bug.