Note: There are a few cases of duplicates in user autocompletion which are being worked on.

crash JNI_CreateJavaVM | sa_stream_destroy

RESOLVED FIXED in Firefox -esr10



6 years ago
5 years ago


(Reporter: WG9s, Assigned: kinetik)


(4 keywords)

10 Branch
crash, regression, reproducible, topcrash

Firefox Tracking Flags

(firefox10-, firefox-esr1012+ fixed)


(Whiteboard: [native-crash][mobile-crash], crash signature, URL)


(2 attachments)



6 years ago
This bug was filed from the Socorro interface and is 
report bp-23e33a0e-f29f-418b-a33f-fb7962111124 .

Comment 1

6 years ago
Trying to play the OGG file in this attachment from bug 704450 crashes on a Samsung Galaxy Tab 8.9.
Component: General → Video/Audio
Product: Fennec → Core
QA Contact: general →
Version: Firefox 10 → 10 Branch
Frame 	Module 	Signature [Expand] 	Source
0 	JNI_CreateJavaVM 	
1 	sa_stream_destroy 	media/libsydneyaudio/src/sydney_audio_android.c:280
2 	nsNativeAudioStream::Init 	content/media/nsAudioStream.cpp:424
3 	mozilla::dom::AudioParent::AudioParent 	dom/ipc/AudioParent.cpp:303
4 	mozilla::dom::ContentParent::AllocPAudio 	dom/ipc/ContentParent.cpp:876
5 	mozilla::dom::PContentParent::OnMessageReceived 	obj-firefox/ipc/ipdl/PContentParent.cpp:851
6 	mozilla::ipc::AsyncChannel::OnDispatchMessage 	ipc/glue/AsyncChannel.cpp:294
7 	mozilla::ipc::RPCChannel::OnMaybeDequeueOne 	ipc/glue/RPCChannel.cpp:433
8 	RunnableMethod<mozilla::ipc::RPCChannel, bool , Tuple0>::Run 	ipc/chromium/src/base/tuple.h:383
9 	mozilla::ipc::RPCChannel::DequeueTask::Run 	RPCChannel.h:464
10 	MessageLoop::RunTask 	ipc/chromium/src/base/
11 	MessageLoop::DeferOrRunPendingTask 	ipc/chromium/src/base/
12 	MessageLoop::DoWork 	ipc/chromium/src/base/
13 	mozilla::ipc::DoWorkRunnable::Run 	ipc/glue/MessagePump.cpp:70
14 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:631
15 	NS_ProcessNextEvent_P 	obj-firefox/xpcom/build/nsThreadUtils.cpp:245
16 	mozilla::ipc::MessagePump::Run 	ipc/glue/MessagePump.cpp:110
17 	MessageLoop::RunInternal 	ipc/chromium/src/base/
18 	MessageLoop::Run 	ipc/chromium/src/base/
19 	nsBaseAppShell::Run 	widget/src/xpwidgets/nsBaseAppShell.cpp:189
20 	nsAppStartup::Run 	toolkit/components/startup/nsAppStartup.cpp:228
21 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3551
22 	Java_org_mozilla_gecko_GeckoAppShell_nativeRun 	toolkit/xre/nsAndroidStartup.cpp:132
23 	Java_org_mozilla_gecko_GeckoAppShell_nativeRun 	other-licenses/android/APKOpen.cpp:232
24 	dvmPlatformInvoke 	
25 	dvmCallJNIMethod_general 	
26 	dvmResolveNativeMethod 	
27 	dvmAsmSisterStart 	
28 	dvmMterpStd 	
29 	dvmInterpret 	
30 	dvmCallMethodV 	
31 	dvmCallMethod 	
32 	dvmAttachCurrentThread 	
33 	__thread_entry 	
34 	pthread_create 	
35 		@0x5e8301ae
Keywords: reproducible
Whiteboard: [native-crash]

Comment 3

6 years ago
That audio file has a non-standard sample-rate.

Using this file newly attached results in a file that plays without crashing:

Perhaps for Android we should have a list of valid sample rates and not try to play things not in the list?

Comment 4

6 years ago
Adding regression Keyword and requesting tracking Firefox 10 because this does not crash in the current Firefox version 9 beta.
tracking-firefox10: --- → ?
Keywords: regression

Comment 5

6 years ago
Created attachment 576810 [details] [diff] [review]
Assignee: nobody → kinetik
Attachment #576810 - Flags: review?(doug.turner)

Comment 6

6 years ago
Comment on attachment 576810 [details] [diff] [review]

Review of attachment 576810 [details] [diff] [review]:

::: media/libsydneyaudio/src/sydney_audio_android.c
@@ +119,4 @@
>  static jclass
>  init_jni_bindings(JNIEnv *jenv) {
> +  jclass class = (*jenv)->FindClass(jenv, "android/media/AudioTrack");

I am kinda of surprised that this returns null.
Attachment #576810 - Flags: review?(doug.turner) → review+

Comment 7

6 years ago
land on m-c, we can merge back to birch whenever.

Comment 8

6 years ago
Using my own build including this patch, I am unable to reproduce the crash.


6 years ago
Summary: crash JNI_CreateJavaVM → crash JNI_CreateJavaVM | sa_stream_destroy

Comment 9

6 years ago
Target Milestone: --- → mozilla11
Last Resolved: 6 years ago
Resolution: --- → FIXED
Setting tracking flag for 10 to - since crash-stats does not suggest that this is occurring in FF10beta2.
tracking-firefox10: ? → -

Comment 12

5 years ago
It's #9 top browser crasher in Fennec 10.0.3esr.
status-firefox-esr10: --- → affected
tracking-firefox-esr10: --- → ?
Keywords: topcrash
Whiteboard: [native-crash] → [native-crash][!mobile-crash]
Matthew - how do you feel about the risk to the ESR10 branch (desktop and mobile) if we try to fix on that branch? Thanks in advance.

Comment 14

5 years ago
The code is only used on Android, so the risk is limited to that platform.  It's a straightforward fix, so I'd rate the risk on Android as very low.


5 years ago
Whiteboard: [native-crash][!mobile-crash] → [native-crash][mobile-crash]
[Triage Comment]
Please go ahead and prepare/nominate a patch for ESR branch, see
tracking-firefox-esr10: ? → 12+

Comment 16

5 years ago
Created attachment 613028 [details] [diff] [review]
esr patch v0

Slightly rebased due to missing patches on ESR.
Attachment #613028 - Flags: approval-mozilla-esr10?

Comment 17

5 years ago
ESR try push:
(In reply to Matthew Gregan [:kinetik] from comment #17)
> ESR try push:

So that push is entirely red - have you another? :)

Comment 19

5 years ago
Building Android ESR on try seems to require additional magic.  Let's see if this one works:

Comment 20

5 years ago
(In reply to Matthew Gregan [:kinetik] from comment #19)

Builds are green.  I think that's good enough--the only difference in this patch compared to the original patch is removal of a few lines freeing resources that aren't allocated in the earlier versions of the code--the changes have effectively been tested by the original patch landing.

I don't know what's up with the tests in this try push, they're all failing to even start due to a config issue/difference on try vs the ESR build config.
Comment on attachment 613028 [details] [diff] [review]
esr patch v0

Thanks for preparing this.
Attachment #613028 - Flags: approval-mozilla-esr10? → approval-mozilla-esr10+
(In reply to Matthew Gregan [:kinetik] from comment #20)

> I don't know what's up with the tests in this try push, they're all failing
> to even start due to a config issue/difference on try vs the ESR build
> config.

When you land on ESR can you please confirm back in there that the test runs on ESR branch don't mimic what we're seeing on the try push?

Comment 23

5 years ago
(In reply to Lukas Blakk [:lsblakk] from comment #22)
> When you land on ESR can you please confirm back in there that the test runs
> on ESR branch don't mimic what we're seeing on the try push?

Will do.
status-firefox-esr10: affected → fixed

Comment 24

5 years ago
(In reply to Matthew Gregan [:kinetik] from comment #23)

Android tests ran fine (other than a few existing intermittent failures), so this looks good.
You need to log in before you can comment on or make changes to this bug.