Last Comment Bug 705133 - move all linux CC and CXX lines to a central mozconfig snippet
: move all linux CC and CXX lines to a central mozconfig snippet
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All Linux
: -- normal (vote)
: mozilla11
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-24 07:16 PST by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2011-11-25 02:25 PST (History)
3 users (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
move all linux CC and CXX lines to a central mozconfig snippet (10.21 KB, patch)
2011-11-24 07:20 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
no flags Details | Diff | Splinter Review
move all linux CC and CXX lines to a central mozconfig snippet (10.41 KB, patch)
2011-11-24 07:26 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
catlee: review-
Details | Diff | Splinter Review
move all linux CC and CXX lines to a central mozconfig snippet (10.38 KB, patch)
2011-11-24 11:33 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
catlee: review+
Details | Diff | Splinter Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-24 07:16:17 PST

    
Comment 1 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-24 07:20:37 PST
Created attachment 576762 [details] [diff] [review]
move all linux CC and CXX lines to a central mozconfig snippet

https://tbpl.mozilla.org/?tree=Try&rev=ca978ba45b1f
Comment 2 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-24 07:26:51 PST
Created attachment 576763 [details] [diff] [review]
move all linux CC and CXX lines to a central mozconfig snippet

https://tbpl.mozilla.org/?tree=Try&rev=53d28e4b032b
Comment 3 Chris AtLee [:catlee] 2011-11-24 10:59:22 PST
Comment on attachment 576763 [details] [diff] [review]
move all linux CC and CXX lines to a central mozconfig snippet

Review of attachment 576763 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/mozconfig.linux
@@ +1,2 @@
> +. $topsrcdir/build/unix/mozconfig.linux
> +

I think you want actual contents here like

CC=/tools/gcc-4.5-0moz2/bin/gc
CXX=/tools/gcc-4.5-0moz2/bin/g++
Comment 4 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-24 11:33:13 PST
Created attachment 576808 [details] [diff] [review]
move all linux CC and CXX lines to a central mozconfig snippet

I guess I ran sed before and after adding the file :-(

Fixed now.
Comment 5 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-24 11:33:37 PST
https://tbpl.mozilla.org/?tree=Try&rev=348b9f1e7218
Comment 6 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-24 12:00:27 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1472d3eb887
Comment 7 Mounir Lamouri (:mounir) 2011-11-25 02:25:03 PST
https://hg.mozilla.org/mozilla-central/rev/b1472d3eb887

Note You need to log in before you can comment on or make changes to this bug.