705156 - embedding/test/test_window_open_units.html is flaky

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

When I push my WebSMS patch queue to try I got this perma-orange on Windows 7 Opt:
40 ERROR TEST-UNEXPECTED-FAIL | /tests/embedding/test/test_window_open_units.html | wrong width - got 398, expected 400
41 ERROR TEST-UNEXPECTED-FAIL | /tests/embedding/test/test_window_open_units.html | wrong height - got 198, expected 200 

I did look in bugzilla to see if there was known failures related to that tests and it happen that other people (bug 626064 and bug 661877). Both got the same perma-orange.

I believe the test is flaky and for some reasons those bugs are triggering the issue. According to bug 661877 it might be related to directories and like Jan, I'm adding a new test directory inside of dom/.

Is it correct to assume that the window size will be exactly what we are asking for? Should we look for a size "around" the one we did request (with delta=2 for example)? Otherwise, roc, what would you propose to fix that test?

Note: this is currently blocking me from pushing a part of WebSMS implementation to mozilla-central.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/dfb4684b40e0