Closed Bug 705272 Opened 8 years ago Closed 8 years ago

[CC] Don't traverse the hidden window

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: mccr8, Assigned: smaug)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It looks to me like the hidden window is created on startup, and lasts until shutdown.  Thus we should not traverse it.  This contains things (looks like maybe 500 DOM nodes?) and is traversed on OSX.  It contains things on Windows, even though it is a different type of document, but I don't know if it is really traversed there.  Hopefully this is doable by modifying nsCCUncollectableMarker.  I'm not sure why it isn't caught by that already.
Attached patch patchSplinter Review
Does the patch help+
Attachment #576929 - Flags: feedback?(continuation)
Comment on attachment 576929 [details] [diff] [review]
patch

This prevents the hidden window from being traversed, thanks!

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=d1c5a9775853

It looked like that all documents were being traversed in the CC before the shutdown CC, which is odd, but I can't imagine this patch is at fault.  I'll have to keep an eye on that.
Attachment #576929 - Flags: feedback?(continuation) → feedback+
Attachment #576929 - Flags: review?(jst)
Attachment #576929 - Flags: review?(jst) → review+
https://hg.mozilla.org/mozilla-central/rev/4c3b8d006a0d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee: nobody → bugs
Target Milestone: --- → mozilla11
Blocks: 716598
No longer blocks: 698919
You need to log in before you can comment on or make changes to this bug.