The default bug view has changed. See this FAQ.

[CC] Don't traverse the hidden window

RESOLVED FIXED in mozilla11

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: smaug)

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
It looks to me like the hidden window is created on startup, and lasts until shutdown.  Thus we should not traverse it.  This contains things (looks like maybe 500 DOM nodes?) and is traversed on OSX.  It contains things on Windows, even though it is a different type of document, but I don't know if it is really traversed there.  Hopefully this is doable by modifying nsCCUncollectableMarker.  I'm not sure why it isn't caught by that already.
Created attachment 576929 [details] [diff] [review]
patch

Does the patch help+
Attachment #576929 - Flags: feedback?(continuation)
(Reporter)

Comment 2

5 years ago
Comment on attachment 576929 [details] [diff] [review]
patch

This prevents the hidden window from being traversed, thanks!

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=d1c5a9775853

It looked like that all documents were being traversed in the CC before the shutdown CC, which is odd, but I can't imagine this patch is at fault.  I'll have to keep an eye on that.
Attachment #576929 - Flags: feedback?(continuation) → feedback+
Attachment #576929 - Flags: review?(jst)

Updated

5 years ago
Attachment #576929 - Flags: review?(jst) → review+
https://hg.mozilla.org/mozilla-central/rev/4c3b8d006a0d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → bugs
(Reporter)

Updated

5 years ago
Target Milestone: --- → mozilla11
(Reporter)

Updated

5 years ago
Blocks: 716598
(Reporter)

Updated

5 years ago
No longer blocks: 698919
You need to log in before you can comment on or make changes to this bug.