Ready for localization email should have a diff

VERIFIED FIXED in 2012-01-31

Status

support.mozilla.org
Knowledge Base Software
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: atopal, Assigned: timw)

Tracking

unspecified
2012-01-31

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=contributor c=wiki s=2012.2 p=1)

(Reporter)

Description

6 years ago
Currently the email about an article that is ready for localization only shows the full article in source. That's not useful to localizers at all. Please show a diff between the last ready for l10n version and the current one on top of the email.
(Assignee)

Updated

6 years ago
Assignee: nobody → timw
(Assignee)

Comment 1

6 years ago
https://github.com/jsocol/kitsune/pull/356
(Assignee)

Updated

6 years ago
Target Milestone: 2011-12-06 → 2011-12-13
(Assignee)

Comment 2

6 years ago
https://github.com/jsocol/kitsune/compare/8f7a844...49700bb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Verified 'text of the new revision' displays at the top of the email.
Status: RESOLVED → VERIFIED
(Reporter)

Comment 4

6 years ago
Actually this bug is not fixed. Rebecca, 'text of the new revision' shows the new text for the whole page. The diff should have the header "changes" and only show the diff with added and removed lines. 

I looked into my "ready for l10n" mails, and none head the diff on top.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Whiteboard: u=contributor c=wiki s=2012.2 p=
Whiteboard: u=contributor c=wiki s=2012.2 p= → u=contributor c=wiki s=2012.2 p=1
Target Milestone: 2011-12-13 → 2012Q1
(Assignee)

Comment 5

6 years ago
Can you past some example emails here?
Assignee: timw → a.topal
(Assignee)

Comment 6

6 years ago
paste*
(Reporter)

Comment 7

6 years ago
Subject: Navigation Toolbar items has a revision ready for localization

Body:

The document Navigation Toolbar items has a new revision
that is ready for localization.

To localize the document, click the following link, or paste it into
your browser's location bar:

https://support.mozilla.org/en-US/kb/Navigation%20Toolbar%20items/translate


--
Text of the new revision:
The Navigation toolbar contains the tools used to navigate to websites, as well as the Location bar and Search bar.
* If you find that one of the items below is missing from your toolbar, see the [[Back and forward or other toolbar items are missing|Toolbar items missing]] article to restore them.
{for =fx8,=fx9}
{for win}[[Image:Navigation Toolbar - Win1]]{/for}{for mac}[[Image:Navigation Toolbar - Mac1]]{/for}
{/for}
...
...
(Reporter)

Updated

6 years ago
Assignee: a.topal → timw
(Assignee)

Comment 8

6 years ago
Verify that the difference in revisions actually exists. That is the only why it will be displayed.
If you have a revision that is different from the documents _current_ revision and the email did not display the diff, could you paste the links here.

https://github.com/readevalprint/kitsune/blob/master/apps/wiki/templates/wiki/email/ready_for_l10n.ltxt#L9
Assignee: timw → a.topal
(Assignee)

Comment 9

6 years ago
nm, we need to change the logic for localized revision
(Assignee)

Updated

6 years ago
Assignee: a.topal → timw
(Assignee)

Comment 10

6 years ago
https://github.com/mozilla/kitsune/compare/448c35c...141d451
https://ci.mozilla.org/job/sumo-master/1325/
https://github.com/mozilla/kitsune/pull/443
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 11

6 years ago
Just to be sure: this is diffing to the last revision that was marked as ready for localization, not just to the last approved revision, right?
(In reply to Kadir Topal [:atopal] from comment #11)
> Just to be sure: this is diffing to the last revision that was marked as
> ready for localization, not just to the last approved revision, right?

correct
Target Milestone: 2012Q1 → 2012-01-31
Verified new translations show full text to be translated. Verified translations go from last approved revision marked ready to localize. Verified text of email shows doc ready to translate with link, then list of  -/+ changes, then the text.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.