705440 - Add "Keyword already taken" warning when adding existing keyword for bookmark

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, enhancement)

Description

[maxjmaass]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243

Steps to reproduce:

I added Goodreads.com as a search engine and tried to give it the quick access word "gr" (I don't know how this feature is called in english, I am using the german firefox and it is called "Schlüsselwort"). I don't have any other search engines with the quick access word "gr", only "g" for google. Any other word seems to work though, even "gre".


Actual results:

The word did not appear in the list and did not work when I tried to use it.


Expected results:

"gr" should have appeared next to the entry of the search engine, and "gr [something]" should search goodreads for [something], as you know.

Comment 1

[maxjmaass]

*cough* I found out why. I gave "gr" to a bookmark. Consider this a feature Request now: Please add a message box that tells the user that this word is taken.

Comment 2

[maxjmaass]

Is this currently being worked on? Checking the latest source, I found the following in /mozilla-beta/browser/components/search/content/engineManager.js:
Line 189 to 202
// Notify the user if they have chosen an existing engine/bookmark keyword
      if (eduplicate || bduplicate) {
        var dtitle = strings.getString("duplicateTitle");
        var bmsg = strings.getString("duplicateBookmarkMsg");
        var emsg = strings.getFormattedString("duplicateEngineMsg",
                                              [engine.name]);

        prompt.alert(window, dtitle, (eduplicate) ? emsg : bmsg);
      } else {
        gEngineView._engineStore.changeEngine(selectedEngine, "alias",
                                              alias.value);
        gEngineView.invalidate();
        break;
      }

Comment 3

[Matthew N. [:MattN]]

Checking for duplicates in the search engine window is already implemented (recently fixed in bug 709589).  Checking for duplicates when editing a bookmark is bug 386059.  It seems like this bug report is a dupe of one of them.

Comment 4

[Nickolay_Ponomarev]

> I added Goodreads.com as a search engine and tried to give it the quick access word "gr"

Where did you try to do that (it's not clear from your steps to reproduce)? In the "Manage Search Engines..." dialog? It should warn about the keyword being used in a bookmark keyword search already (per bug 378553)...

Comment 5

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.