Last Comment Bug 705443 - Use IDL for nsIDOMWindowUtils::GetClassName
: Use IDL for nsIDOMWindowUtils::GetClassName
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-26 07:17 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-12-04 14:09 PST (History)
0 users
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (2.80 KB, patch)
2011-11-26 07:17 PST, :Ms2ger (⌚ UTC+1/+2)
khuey: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-11-26 07:17:50 PST
Created attachment 577070 [details] [diff] [review]
Patch v1
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-11-26 07:21:22 PST
Comment on attachment 577070 [details] [diff] [review]
Patch v1

Review of attachment 577070 [details] [diff] [review]:
-----------------------------------------------------------------

This needs an IID change too.

::: dom/base/nsDOMWindowUtils.cpp
@@ +1470,1 @@
>    return *aName ? NS_OK : NS_ERROR_OUT_OF_MEMORY;

NS_strdup is infallible.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-12-04 14:09:57 PST
https://hg.mozilla.org/mozilla-central/rev/09f69613e8eb

Note You need to log in before you can comment on or make changes to this bug.