Last Comment Bug 705461 - Use MOZ_CHECK_HEADER(S) everywhere
: Use MOZ_CHECK_HEADER(S) everywhere
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla11
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
Mentors:
Depends on:
Blocks: 705466
  Show dependency treegraph
 
Reported: 2011-11-26 10:16 PST by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2011-11-28 08:24 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use MOZ_CHECK_HEADER(S) everywhere (14.14 KB, patch)
2011-11-26 10:24 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
no flags Details | Diff | Splinter Review
Use MOZ_CHECK_HEADER(S) everywhere (17.00 KB, patch)
2011-11-26 10:39 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
neil: review+
ted: feedback+
Details | Diff | Splinter Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-26 10:16:05 PST

    
Comment 1 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-26 10:24:55 PST
Created attachment 577087 [details] [diff] [review]
Use MOZ_CHECK_HEADER(S) everywhere

https://tbpl.mozilla.org/?tree=Try&rev=7a6b35a3cf3c
Comment 2 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-26 10:39:00 PST
Created attachment 577090 [details] [diff] [review]
Use MOZ_CHECK_HEADER(S) everywhere

https://tbpl.mozilla.org/?tree=Try&rev=fcf1c80261c5
Comment 3 neil@parkwaycc.co.uk 2011-11-26 11:44:57 PST
Comment on attachment 577090 [details] [diff] [review]
Use MOZ_CHECK_HEADER(S) everywhere

>-    	AC_CHECK_HEADERS(mmintrin.h)
>+    	MOZ_CHECK_HEADERS(mmintrin.h)
[When I patched mozilla-central's configure.in I changed this tab to spaces.]
Comment 4 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-26 13:06:36 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/300d9c4a3b9a
Comment 5 Marco Bonardo [::mak] 2011-11-28 05:23:36 PST
https://hg.mozilla.org/mozilla-central/rev/300d9c4a3b9a
Comment 6 Ted Mielczarek [:ted.mielczarek] 2011-11-28 08:24:20 PST
Comment on attachment 577090 [details] [diff] [review]
Use MOZ_CHECK_HEADER(S) everywhere

Review of attachment 577090 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, FWIW.

Note You need to log in before you can comment on or make changes to this bug.