70569 - dead code doesn't belong in tree

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[timeless]

cyeh (7 warnings) all for `void wallet_'.something.'()' defined but not used

Comment 1

[timeless]

Attachment: clean out cyeh debug code

Comment 2

[timeless]

ignore the two +'s, they're from morse warning cleanup [along w/ other elements 
which i redacted]. please review.

Comment 3

[timeless]

addendum, zap sfraser's function
13a30,36
> -wallet_DumpAutoString(const nsString& as){
> -  char s[100];
> -  as.ToCString(s, sizeof(s));
> -  fprintf(stdout, "%s\n", s);
> -}
> -
> -static void

Comment 4

[Stephen P. Morse]

Why do you want to remove any of this code?  It is all within ifdef DEBUG 
statements already so it is not part of the optimized build.  And I frequently 
use these routines for finding problems.

Comment 5

[Chris Yeh]

removing myself from cc. this code probably got checked in under my name during 
some previous code cleaning action or during a tree fix from over a year ago.

morse is the best person to review any potential fixes.

Comment 6

[timeless]

i'm cleaning out warnings and unused code. if you don't want the code deleted, 
would you ok my moving it into an ifdef DEBUG_morse?

Comment 7

[Stephen P. Morse]

Sure.  That's better than deleting it.

Comment 8

[timeless]

Attachment: wallet warning cleanup

Comment 9

[Stephen P. Morse]

r=morse

Comment 10

[Brendan Eich [:brendan]]

sr=[e-mail]

Comment 11

[timeless]

fix checked in. 1 module done many to go.

Comment 12

[Terri Preston]

Verified code checked into lxr.mozilla.org