705878 - Refactor forgot_password to use different controllers depending on parameters

Status: RESOLVED FIXED

(Cloud Services :: Server: Account Portal, defect)

Description

[Toby Elliott [:telliott]]

forgot_password is a pretty monolithic function, involving a bunch of different GETs and POSTs, which means you could conceivably do weird (though not dangerous things) with passing in parameters. Should look into refactoring it now that we have pyramid and can do better routing refinement.

Comment 1

[Toby Elliott [:telliott]]

Attachment: Refactors forgot password, which also required a bit of template changing

This one's a little more complex, as it has different templates for each stage and sometimes needs to jump tracks.

Comment 2

[Ben Bangert [:benbangert]]

Comment on attachment 579358 [details] [diff] [review]
Refactors forgot password, which also required a bit of template changing

Review of attachment 579358 [details] [diff] [review]:
-----------------------------------------------------------------

::: accountportal/controllers/console.py
@@ +212,5 @@
> +    auth = request.registry.settings.get('app.auth')
> +    username = extract_username(request.params.get('username'))
> +    request.user['username'] = username
> +    data['key'] = request.params['key']
> +    data['usernm'] = username  #needs to be different from the session username

Just double checking, this is supposed to be 'usernm' vs. 'username' in data? Is there already a data['username'] key?

Comment 3

[Toby Elliott [:telliott]]

Yes, there is. It's not a typo. That's what the comment is for.

data['username'] is automatically populated by the BeforeRender subscriber.

Comment 4

[Toby Elliott [:telliott]]

updated in http://hg.mozilla.org/services/account-portal/rev/5d7905023e2f