The default bug view has changed. See this FAQ.

Web console filter button should retain checked state when any of its menuitems are checked

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Developer Tools: Console
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: harth, Assigned: harth)

Tracking

Trunk
Firefox 11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
After bug 702342, a filter button stays checked when you uncheck some (but not all) of its menuitems.

However, when you re-open the console (after bug 622303 landed), the main filter button will be unchecked if any of its menuitems are unchecked. We need to make this consistent.
(Assignee)

Comment 1

5 years ago
Created attachment 577391 [details] [diff] [review]
Check filter button if any of its menuitems are checked when loading state from prefs

Patch to fix this and some test cases.
Assignee: nobody → fayearthur
Attachment #577391 - Flags: review?(mihai.sucan)
Comment on attachment 577391 [details] [diff] [review]
Check filter button if any of its menuitems are checked when loading state from prefs

Review of attachment 577391 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Thank you Heather!

::: browser/devtools/webconsole/test/browser/browser_webconsole_bug_622303_persistent_filters.js
@@ +25,5 @@
> +    ]
> +  };
> +
> +  // Set all prefs to true
> +  for (category in prefs) {

Please do |let category|.
Attachment #577391 - Flags: review?(mihai.sucan) → review+

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Summary: Main filter button should retain checked state when any of its menuitems are checked → Web console filter button should retain checked state when any of its menuitems are checked
(Assignee)

Comment 3

5 years ago
(In reply to Mihai Sucan [:msucan] from comment #2)
> 
> Please do |let category|.

Nice catch, thanks. fx-team:

http://hg.mozilla.org/integration/fx-team/rev/d4c22093b301
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d4c22093b301
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.