Last Comment Bug 705903 - Web console filter button should retain checked state when any of its menuitems are checked
: Web console filter button should retain checked state when any of its menuite...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 11
Assigned To: Heather Arthur [:harth]
:
: Brian Grinstead [:bgrins]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-28 14:59 PST by Heather Arthur [:harth]
Modified: 2011-11-29 22:08 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Check filter button if any of its menuitems are checked when loading state from prefs (6.53 KB, patch)
2011-11-28 15:01 PST, Heather Arthur [:harth]
mihai.sucan: review+
Details | Diff | Splinter Review

Description Heather Arthur [:harth] 2011-11-28 14:59:29 PST
After bug 702342, a filter button stays checked when you uncheck some (but not all) of its menuitems.

However, when you re-open the console (after bug 622303 landed), the main filter button will be unchecked if any of its menuitems are unchecked. We need to make this consistent.
Comment 1 Heather Arthur [:harth] 2011-11-28 15:01:21 PST
Created attachment 577391 [details] [diff] [review]
Check filter button if any of its menuitems are checked when loading state from prefs

Patch to fix this and some test cases.
Comment 2 Mihai Sucan [:msucan] 2011-11-29 09:43:04 PST
Comment on attachment 577391 [details] [diff] [review]
Check filter button if any of its menuitems are checked when loading state from prefs

Review of attachment 577391 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Thank you Heather!

::: browser/devtools/webconsole/test/browser/browser_webconsole_bug_622303_persistent_filters.js
@@ +25,5 @@
> +    ]
> +  };
> +
> +  // Set all prefs to true
> +  for (category in prefs) {

Please do |let category|.
Comment 3 Heather Arthur [:harth] 2011-11-29 12:09:36 PST
(In reply to Mihai Sucan [:msucan] from comment #2)
> 
> Please do |let category|.

Nice catch, thanks. fx-team:

http://hg.mozilla.org/integration/fx-team/rev/d4c22093b301
Comment 4 Tim Taubert [:ttaubert] 2011-11-29 22:08:40 PST
https://hg.mozilla.org/mozilla-central/rev/d4c22093b301

Note You need to log in before you can comment on or make changes to this bug.