Closed Bug 705903 Opened 10 years ago Closed 10 years ago

Web console filter button should retain checked state when any of its menuitems are checked

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 11

People

(Reporter: harth, Assigned: harth)

Details

Attachments

(1 file)

After bug 702342, a filter button stays checked when you uncheck some (but not all) of its menuitems.

However, when you re-open the console (after bug 622303 landed), the main filter button will be unchecked if any of its menuitems are unchecked. We need to make this consistent.
Patch to fix this and some test cases.
Assignee: nobody → fayearthur
Attachment #577391 - Flags: review?(mihai.sucan)
Comment on attachment 577391 [details] [diff] [review]
Check filter button if any of its menuitems are checked when loading state from prefs

Review of attachment 577391 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Thank you Heather!

::: browser/devtools/webconsole/test/browser/browser_webconsole_bug_622303_persistent_filters.js
@@ +25,5 @@
> +    ]
> +  };
> +
> +  // Set all prefs to true
> +  for (category in prefs) {

Please do |let category|.
Attachment #577391 - Flags: review?(mihai.sucan) → review+
Status: NEW → ASSIGNED
Summary: Main filter button should retain checked state when any of its menuitems are checked → Web console filter button should retain checked state when any of its menuitems are checked
(In reply to Mihai Sucan [:msucan] from comment #2)
> 
> Please do |let category|.

Nice catch, thanks. fx-team:

http://hg.mozilla.org/integration/fx-team/rev/d4c22093b301
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d4c22093b301
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
Version: unspecified → Trunk
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.