705903 - Web console filter button should retain checked state when any of its menuitems are checked

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Heather Arthur [:harth]]

After bug 702342, a filter button stays checked when you uncheck some (but not all) of its menuitems.

However, when you re-open the console (after bug 622303 landed), the main filter button will be unchecked if any of its menuitems are unchecked. We need to make this consistent.

Comment 1

[Heather Arthur [:harth]]

Attachment: Check filter button if any of its menuitems are checked when loading state from prefs

Patch to fix this and some test cases.

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 577391 [details] [diff] [review]
Check filter button if any of its menuitems are checked when loading state from prefs

Review of attachment 577391 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Thank you Heather!

::: browser/devtools/webconsole/test/browser/browser_webconsole_bug_622303_persistent_filters.js
@@ +25,5 @@
> +    ]
> +  };
> +
> +  // Set all prefs to true
> +  for (category in prefs) {

Please do |let category|.

Comment 3

[Heather Arthur [:harth]]

(In reply to Mihai Sucan [:msucan] from comment #2)
> 
> Please do |let category|.

Nice catch, thanks. fx-team:

http://hg.mozilla.org/integration/fx-team/rev/d4c22093b301

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/d4c22093b301