Chrome migrator should notify of Migration:ItemError when there are errors

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Migration
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

Trunk
Firefox 11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 577530 [details] [diff] [review]
v0.1 Notify on error for cookies, history & bookmarks

The migrator should notify of "Migration:ItemError" when there is an error migrating a specific item.  This is for consistency with the other migrators.
Attachment #577530 - Flags: review?(mak77)
Comment on attachment 577530 [details] [diff] [review]
v0.1 Notify on error for cookies, history & bookmarks

Review of attachment 577530 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/migration/src/ChromeProfileMigrator.js
@@ +153,5 @@
> +   * Notify observers that a migration error occured with an item
> +   *
> +   * @param   aType
> +   *          notification type such as MIGRATE_BOOKMARKS
> +   */

sigh, javadocs should begin with /** looks like a global nit for all the migrator, I thought I commented about this in the original bug...
Attachment #577530 - Flags: review?(mak77) → review+
Blocks: 505192
No longer depends on: 505192
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a5a28f62c4d
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/2a5a28f62c4d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.