Closed
Bug 706033
Opened 13 years ago
Closed 13 years ago
Chrome migrator should notify of Migration:ItemError when there are errors
Categories
(Firefox :: Migration, defect)
Firefox
Migration
Tracking
()
RESOLVED
FIXED
Firefox 11
People
(Reporter: MattN, Assigned: MattN)
References
Details
Attachments
(1 file)
2.53 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
The migrator should notify of "Migration:ItemError" when there is an error migrating a specific item. This is for consistency with the other migrators.
Attachment #577530 -
Flags: review?(mak77)
Comment 1•13 years ago
|
||
Comment on attachment 577530 [details] [diff] [review]
v0.1 Notify on error for cookies, history & bookmarks
Review of attachment 577530 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/components/migration/src/ChromeProfileMigrator.js
@@ +153,5 @@
> + * Notify observers that a migration error occured with an item
> + *
> + * @param aType
> + * notification type such as MIGRATE_BOOKMARKS
> + */
sigh, javadocs should begin with /** looks like a global nit for all the migrator, I thought I commented about this in the original bug...
Attachment #577530 -
Flags: review?(mak77) → review+
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Comment 2•13 years ago
|
||
Target Milestone: --- → Firefox 11
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•