Upload custom icon does not work in IE9, Safari

VERIFIED FIXED in 6.3.4

Status

addons.mozilla.org Graveyard
Public Pages
P3
normal
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: Cristian Boldan, Assigned: spasovski)

Tracking

unspecified
6.3.4
x86_64
Windows 7

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 577549 [details]
upload icon Safari

Steps to reproduce:
1. Login to AMO apps page https://apps-preview-dev.allizom.org/en-US/apps/
2. Submit a new app to get to step 4
3. Upload a custom icon

Expected Results:
Preview of the uploaded image is shown

Actual Results:
Preview is not showing and custom icon is not uploaded. The default icon is not changing on IE9 and on Safari a question mark is shown in the preview areas

Notes/Issues:
Verified on IE9 and Safari (Win7 and MacOSX)
Attaching screenshot for this issue on Safari
Screencast for this issue on IE9 http://screencast.com/t/Lqs7d7dfGN
(Reporter)

Updated

7 years ago
Blocks: 690899
Summary: Upload custom Icon does not work in Apps Developer Preview → Upload custom icon does not work in IE9, Safari
Assignee: nobody → dspasovski
Priority: -- → P3
Target Milestone: --- → 6.3.4
(Assignee)

Comment 1

7 years ago
Done: https://github.com/mozilla/zamboni/commit/88d22270

The correct behavior should now be that the icon preview area disappears for browsers that don't support formdata like safari and ie9.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

7 years ago
Issue still reproducing in IE9 and Safari.
Screencast for IE9 http://screencast.com/t/vsxeIShb
Screencast for Safari http://screencast.com/t/Z0QEwwfQPbQ
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 3

7 years ago
Seems an old JS asset was used which means the fix didn't make it to staging...should be alright now.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

7 years ago
Issue still reproducing in IE9.
Screencast for IE9 http://screencast.com/t/vsxeIShb
Action behaves as expected on Safari, with no issues  http://screencast.com/t/GPWWViE3
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

7 years ago
IE9 should also be covered now:

https://github.com/mozilla/zamboni/commit/8019e52b
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

7 years ago
Issue still reproducing in IE9.
Screencast fot IE9 http://screencast.com/t/BFd6BqzGj
Icon preview area dissapears, but after the "Save Changes" button is clicked, the image for the icon is not uploaded.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

7 years ago
710303 covers the image submissions not working in IE9, this is a more involved fix that will have to be implemented.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

6 years ago
Fixed by new designs.
Closing bug.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.