Closed Bug 706243 Opened 10 years ago Closed 10 years ago

install android sdk, java on signing1.build

Categories

(Release Engineering :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aki, Unassigned)

References

Details

(Whiteboard: [android][signing][releases][puppet])

Attachments

(1 file, 2 obsolete files)

These are needed for Android signing.
This doesn't block the mozharness port, as I can still use keymaster01 in the meantime.
This does block signing on demand.
whoever does this will find the following command helpful as it allows you to do the sdk update run *after* extracting the tarball wihtout having to be in a GUI.

$ android update sdk --no-ui

you need to run this to actually get all of the recent sdk bits
Can't we reuse the existing linux builder android sdk package?
(In reply to Aki Sasaki [:aki] from comment #2)
> Can't we reuse the existing linux builder android sdk package?

sure can.
Wouldn't it better to puppetize this?
Yes, but I need to know what's on there.
Also, I don't know puppet, but I may be able to copy build packages into the signing configs.
it's already in puppet - puppet installs the SDK and NDK rpms that were created
This gives me

info: Caching catalog for signing1.build.scl1.mozilla.com
info: Applying configuration version '1327614540'
notice: //Signingserver/Service[iptables]/ensure: ensure changed 'stopped' to 'running'
err: //Signingserver/Package[jdk1.6]/ensure: change from absent to latest failed: Could not update: Could not find package jdk1.6 at /etc/puppet/aki/modules/signingserver/manifests/init.pp:33
err: //Signingserver/Package[android-sdk]/ensure: change from absent to latest failed: Could not update: Could not find package android-sdk at /etc/puppet/aki/modules/signingserver/manifests/init.pp:33
notice: Finished catalog run in 15.08 seconds

So I'm guessing that I need to copy some rpms from scl-production-puppet /N/production to master-puppet1 /N/production.  I'm stopping here before I do something unhappy to puppet.
Attachment #591937 - Flags: feedback?(jhford)
Comment on attachment 591937 [details] [diff] [review]
add android sdk + jdk to signing servers

Review of attachment 591937 [details] [diff] [review]:
-----------------------------------------------------------------

this would require putting the rpms into the repos.  In irc, we decided to try copying just the two programs needed (zipalign and jarsigner) using file resources with source parameters.
Attachment #591937 - Flags: feedback?(jhford)
Copying just those two binaries isn't sufficient:

19:38:53     INFO -  /home/cltsign/aki/jarsigner: error while loading shared libraries: libjli.so: cannot open shared object file: No such file or directory
I also need the ffxbld and cltbld ssh keys and stage.m.o and aus2-staging.m.o to be in known_hosts.
what about zipalign?

installing just the jdk is still a space win.

Using package type like:

package {
  "jdk16":
    provider => rpm,
    ensure => installed,
    source => ${platform_fileroot}/RPMs/jdk???.rpm";
}

should work.

Ideally, if you are installing these RPMs, they should be included in the repository that installs the other rpms in that manifest.  I don't know who has access to that repo or the tools needed to regenerate it.
Attached patch working patch (obsolete) — Splinter Review
Attachment #591937 - Attachment is obsolete: true
Attachment #592258 - Flags: review?(catlee)
Comment on attachment 592258 [details] [diff] [review]
working patch

Oops, wrong patch
Attachment #592258 - Flags: review?(catlee)
Attachment #592258 - Attachment is obsolete: true
Attachment #592260 - Flags: review?(catlee)
Comment on attachment 592260 [details] [diff] [review]
this is the patch from master-puppet1

Review of attachment 592260 [details] [diff] [review]:
-----------------------------------------------------------------

looks good!

can you do a quick run with --debug to make sure it's not downloading the rpm every time puppet is run? I think adding an ensure => "1.2.3.4" clause would do that as well (see modules/nagios/manifests/install.pp for an example)
Attachment #592260 - Flags: review?(catlee) → review+
I ran with --debug and didn't see any output with android or jdk in it.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.