706313 - redundant checks for results_server/link in run_tests.py

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

http://hg.mozilla.org/build/talos/file/5ae66b11330f/talos/run_tests.py#l545

  if (results_server != '') and (results_link != ''):
    #send results to the graph server
    try:
      if (results_server is not None and 
          results_server is not '' and 
          results_link is not None and 
          results_link is not ''):

This logic is very redundant.  You basically want results_server and
results_link both not to be False:

  if results_server and results_link:

Comment 1

[Jeff Hammel]

Attachment: a much simpler check

Note that the `is ''` is just plain wrong as it is up to python when it caches instances string literals.  It will *probably* be cached in this case, but it is not guaranteed.

Comment 2

[Jeff Hammel]

Comment on attachment 577791 [details] [diff] [review]
a much simpler check

tested on A*Team staging and with tsvg locally on my Samsung tablet

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 577791 [details] [diff] [review]
a much simpler check

Review of attachment 577791 [details] [diff] [review]:
-----------------------------------------------------------------

that looks so much better!

Comment 4

[Jeff Hammel]

pushed: http://hg.mozilla.org/build/talos/rev/705a12151bf2