Closed Bug 706345 Opened 13 years ago Closed 10 years ago

Global .close-icon class to get the appropriate close icon for the OS

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: pjdkrunkt, Unassigned)

References

Details

(Keywords: addon-compat)

User Agent: Mozilla/5.0 (Windows NT 5.0; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243

Steps to reproduce:

Firefox currently contains the following close buttons (with more to come in the restyle of the Awesomebar):

TABS:
.tab-close-button
.tabs-closebutton

SIDEBARS/TOOLBARS:
#sidebar-box .tabs-closebutton
.findbar-closebutton
#addonbar-closebutton 
.webconsole-close-button
#highlighter-closebutton 

PANELS/TAB-PANELS/POPUPS:
.messageCloseButton
#allTabs-tab-close-button.tabs-closebutton
#tab-view .groupItem .close
#tab-view .tab .close 
.messageCloseButton.popup-notification-closebutton
.panel-promo-closebutton

I've left out the "search-close" button because this is technically a functionally different button, but all of the ones listed above are functionally identical.  Half of these are brand new to Firefox 4.0 and up.  Each and every one of these requires theme support in the default theme as well as every 3rd party theme.  This can cause problems if a theme author misses a new feature then the new close button will not appear (documentation on theme-impacting changes is currently provided almost exclusively by akayser in a MozillaZine forum thread).



Expected results:

I'm requesting a global .closebutton class defined in global.css for each and every one of these elements, as well as any new close buttons created in new features.  Alternatively it may be even more functional to have three new classes so that each kind of close button can easily have a distinct visual style per usage:

.tabs-closebutton (already defined)
.toolbar-closebutton
.panel-closebutton
OS: Windows 2000 → All
Hardware: x86 → All
This is a fantastic idea. Anything that simplifies theme development and maintenance would be very welcome.
I forgot to add that this would benefit extensions by not requiring them to supply their own close buttons and allow them to automatically follow the theme style.
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Component: General → Theme
Ever confirmed: true
We're actually doing this Australis
Since Firefox 29 use can use .close-icon on all OSs:
https://mxr.mozilla.org/mozilla-central/search?string=.close-icon&find=toolkit%2Fthemes%2F
Blocks: australis
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: addon-compat
Resolution: --- → FIXED
Summary: Request for global .closebutton class → Global .close-icon class to get the appropriate close icon for the OS
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.