Closed Bug 70641 Opened 24 years ago Closed 23 years ago

Cannot setup/change a signature file

Categories

(SeaMonkey :: MailNews: Account Configuration, defect, P2)

Product:
SeaMonkey
Component:
MailNews: Account Configuration
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.1

People

(Reporter: bugzilla, Assigned: sspitzer)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [nsbeta1+]) 

In the account manager, I am not able to change or set a file patch for a 
signature file. The value doesn't stick. This might be a regression of fix for 
bug 41083
nominating nsbeta1. User should be able to set a signature file!
Keywords: nsbeta1, regression
QA Contact: esther → laurel
*** Bug 70902 has been marked as a duplicate of this bug. ***
*** Bug 70878 has been marked as a duplicate of this bug. ***
*** Bug 70902 has been marked as a duplicate of this bug. ***
Interesting, bug http://bugzilla.mozilla.org/show_bug.cgi?id=70301 talks about a
crash after signature file is set (but not saved properly)
marking nsbeta1+
Priority: -- → P2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9
Okay, some tidbits of info to help get this narrowed down:

Build 2001022805 on Win32 crashes when bringing up a new message compose window.
Build 2001010901 actually works.

Another thing I've noticed, is that in the working build (0109) the checkbox 
isn't pre-checked.  In the latest builds where it doesn't work, this checkbox 
is pre-checked.

Bhuvan, the following link might be helpful in tracking the code changes 
between January 9th and the present: http://bonsai.mozilla.org/cvslog.cgi?
file=mozilla/mailnews/base/prefs/resources/content/am-main.xul
Target Milestone: mozilla0.9 → mozilla0.9.1
moving to mozilla0.9.1
fix in hand.  I thought this was a regression from blake's checkins, so I fixed it.

turns out it wasn't.

two problems:

we were using an old style progid, instead of a contract id.

we were using a bogus api on nsILocalFolder.  there is no .unicodePath setter.
we need to call initWithUnicodePath()

part of this got checked in.

the second half is in my tree, I'll attach a patch.



here's the patch that I'll land soon as the tree opens:



Index: AccountManager.js
===================================================================
RCS file: /cvsroot/mozilla/mailnews/base/prefs/resources/content/AccountManager.
js,v
retrieving revision 1.64
diff -u -r1.64 AccountManager.js
--- AccountManager.js   2001/03/22 22:22:20     1.64
+++ AccountManager.js   2001/03/22 23:08:15
@@ -608,7 +608,7 @@
     if (formElement.value) {
       var localfile = Components.classes["@mozilla.org/file/local;1"].createIns
tance(Components.interfaces.nsILocalFile);
 
-      localfile.unicodePath = formElement.value;
+      localfile.initWithUnicodePath(formElement.value);
       return localfile;
     }
     else {

*** Bug 72683 has been marked as a duplicate of this bug. ***
taking from racham.  I'll land my fix when the tree opens.
Assignee: racham → sspitzer
accepting, will land the fix soon.
Status: NEW → ASSIGNED
fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You can now attach and change the path of a signature file on:
2001-04-06 cvs pull at 4:45 on windows 2000.
2001-04-06-08 on Mac OS 9.1
2001-04-06-05 Mandrake 7.2

However, I'm not sure if there is an outstanding issue (if it is, it probably
should be filed as a new bug).  When you clear the path field of the signature
field, and restart mozilla, the field becomes pre-populated with that value. 
This doesn't affect functionality, just *possibly* consistency.  4.x kept that
field clear if you deleted the entry.
OK using apr12 commercial trunk build: linux rh6.2, mac OS 9.0, win98
Status: RESOLVED → VERIFIED
*** Bug 77116 has been marked as a duplicate of this bug. ***
*** Bug 79143 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.