Implement Application.platformIsMac in order to support Lightning Bug 316916

RESOLVED FIXED in seamonkey2.8

Status

SeaMonkey
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
seamonkey2.8

SeaMonkey Tracking Flags

(seamonkey2.8 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.41 KB, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
https://bug316916.bugzilla.mozilla.org/attachment.cgi?id=577462

The patch in Lightning Bug 316916 makes use of Application.platformIsMac which is specific to Thunderbirds SMILE. This will bring us up to parity with SMILE.
(Assignee)

Comment 1

6 years ago
Created attachment 578017 [details] [diff] [review]
Patch v1.0

> +  // For steelIApplication compatibility.
> +  platformIsMac: "nsILocalFileMac" in Components.interfaces
This is how Thunderbird does it. Also it appears to be the officially recommended way on developer.mozilla.org for detecting OSX.

Since this file is preprocessed I think an alternate way is to do this is at compile time e.g.

  platformIsMac:
#ifeq XP_MACOSX
    true
#else
    false
#endif
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #578017 - Flags: review?(neil)

Comment 2

6 years ago
Comment on attachment 578017 [details] [diff] [review]
Patch v1.0

You need to change the interface's IID (uuid), but not the classID...
Attachment #578017 - Flags: review?(neil)
(Assignee)

Comment 3

6 years ago
Created attachment 578255 [details] [diff] [review]
Patch v1.1

> You need to change the interface's IID (uuid), but not the classID...
Oops.
Attachment #578017 - Attachment is obsolete: true
Attachment #578255 - Flags: review?(neil)

Updated

6 years ago
Attachment #578255 - Flags: review?(neil) → review+
(Assignee)

Comment 4

6 years ago
Pushed.
http://hg.mozilla.org/comm-central/rev/c410db14ee60
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-seamonkey2.8: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.8
You need to log in before you can comment on or make changes to this bug.