706453 - Install App button for free apps don't work

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Cristian Boldan]

Steps to reproduce:
1. Login to AMO apps page https://apps-preview-dev.allizom.org/en-US/apps/
2. Click ok "Arts and Entertainment" category
3. Scroll down the page and click "Install App" button from a free app

Expected Results:
Install app floating box is shown containing Install and Cancel buttons

Actual Results:
The page is scrolled up, floating box doesn't appear

Notes/Issues:
Verified on FF8, IE9 and Safari (Win7 and MacOSX)
Screencast for this issue http://screencast.com/t/vMPsvIHH

Comment 1

[krupa raj[:krupa]]

This is mostly in the listing pages. Installing an app from the detail page works fine.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Hovercards are also affected:
https://apps-preview-dev.allizom.org/en-US/apps/app/marble-run-14/?src=cb-dl-home#author-addons

Comment 3

[Gregory Koberger (:gkoberger)]

Should fix it:

https://github.com/mozilla/zamboni/commit/707a68195c

PSA: returning a falsy value inside a $.each() doesn't just exit the function, it exits the loop :)

Comment 4

[Christopher Van Wiemeersch [:cvan]]

Put (In reply to Gregory Koberger (:gkoberger) from comment #3)

> PSA: returning a falsy value inside a $.each() doesn't just exit the
> function, it exits the loop :)

That sounds like a good comment to add to the commit!

Comment 5

[Cristian Boldan]

Verified as fixed in https://apps-preview-dev.allizom.org/en-US/apps/apps/arts-and-entertainment
Postfix screencast for this issue http://screencast.com/t/GpSJvixf
Closing bug.