706498 - [traceback] [prod] Exception: KeyError: 5

Status: VERIFIED FIXED

(Input Graveyard :: Backend, defect)

Description

[Matt Brandt [:mbrandt]]

A handful of ISE's have a accumulated in the last 12 hours. Here are a couple more offensive urls.

/ru/opinion/1876098
/ru/opinion/1931425
/ru/opinion/1794719

Traceback (most recent call last):

 File "/data/www/django/input.mozilla.com/reporter/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/django/input.mozilla.com/reporter/apps/input/decorators.py", line 102, in wrapped
   return f(request, *args, **kwargs)

 File "/data/www/django/input.mozilla.com/reporter/vendor/src/django/django/utils/decorators.py", line 93, in _wrapped_view
   response = view_func(request, *args, **kwargs)

 File "/data/www/django/input.mozilla.com/reporter/apps/input/decorators.py", line 43, in cached_view
   return f(request, *args, **kwargs)

 File "/data/www/django/input.mozilla.com/reporter/apps/feedback/views.py", line 129, in opinion_detail
   return jingo.render(request, template, {'opinion': o})

 File "/data/www/django/input.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 75, in render
   rendered = render_to_string(request, template, context)

 File "/data/www/django/input.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 93, in render_to_string
   return template.render(get_context())

 File "/data/www/django/input.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 189, in render
   return super(Template, self).render(context_dict)

 File "/data/www/django/input.mozilla.com/reporter/vendor/packages/jinja2/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/www/django/input.mozilla.com/reporter/apps/feedback/templates/feedback/opinion.html", line 1, in top-level template code
   {% extends "base.html" %}

 File "/data/www/django/input.mozilla.com/reporter/templates/base.html", line 45, in top-level template code
   {% block content %}{% endblock %}

 File "/data/www/django/input.mozilla.com/reporter/apps/feedback/templates/feedback/opinion.html", line 9, in block "content"
   {{ message_list((opinion,)) }}

 File "/data/www/django/input.mozilla.com/reporter/apps/search/helpers.py", line 92, in message_list
   return render_template(tpl, new_context(**locals()))

 File "/data/www/django/input.mozilla.com/reporter/apps/search/helpers.py", line 60, in render_template
   t = register.env.get_template(template).render(context)

 File "/data/www/django/input.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 189, in render
   return super(Template, self).render(context_dict)

 File "/data/www/django/input.mozilla.com/reporter/vendor/packages/jinja2/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/www/django/input.mozilla.com/reporter/apps/search/templates/search/message_list.html", line 4, in top-level template code
   <li class="message {{ opinion.type.short }}">

 File "/data/www/django/input.mozilla.com/reporter/vendor/packages/jinja2/jinja2/environment.py", line 371, in getattr
   return getattr(obj, attribute)

 File "/data/www/django/input.mozilla.com/reporter/apps/feedback/models.py", line 108, in type
   return OPINION_TYPES[self._type]

KeyError: 5

Comment 1

[Matt Brandt [:mbrandt]]

/ru/opinion/1899682
/ru/opinion/1199259
/ru/opinion/1899699
/ru/opinion/1874169
/ru/opinion/1847074

Comment 2

[Fred Wenzel [:wenzel]]

Dave, can you give this one some attention soon? We're getting a lot of tracebacks there, and presumably every one of those is a user trying (and failing) to see an opinion on Input. Thanks!

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

This is already done.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Still happening on prod, and Dave's gonna push another fix to dev, at least :-)

Comment 5

[Matt Brandt [:mbrandt]]

/ru/opinion/1874626

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

FYI, this is fixed already here:

https://github.com/mozilla/input.mozilla.org/commit/e6708ad39f967a78fc39c64ded94e0a9e69c7f97

But for some reason that fix doesn't seem propogated up to input.stage

Once I solve that with :jason, I'll look at pushing something to prod.

Comment 7

[Zac C (:zac)]

These test cases don't appear to be valid anymore however viewed a selection of messages and they seemed to work fine. Haven't seen this traceback lately either.