As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 706515 - [patch] Non-initialized variables in nsGeolocationProvider.js
: [patch] Non-initialized variables in nsGeolocationProvider.js
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: unspecified
: All All
: -- minor (vote)
: mozilla11
Assigned To: Tobias (:Tobbi) Markus
: Andrew Overholt [:overholt]
Depends on:
  Show dependency treegraph
Reported: 2011-11-30 09:05 PST by Tobias (:Tobbi) Markus
Modified: 2011-12-01 11:24 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch v1 (563 bytes, patch)
2011-11-30 09:05 PST, Tobias (:Tobbi) Markus
doug.turner: review+
Details | Diff | Splinter Review

Description User image Tobias (:Tobbi) Markus 2011-11-30 09:05:32 PST
Created attachment 577991 [details] [diff] [review]
patch v1

In one JS function inside nsGeolocationProvider.js we initialize global variables instead of members of the prototype. This lead to a JS warning in the error console about the use of a non-initialized variable.
Comment 1 User image Doug Turner (:dougt) 2011-11-30 10:19:56 PST
Comment on attachment 577991 [details] [diff] [review]
patch v1

Review of attachment 577991 [details] [diff] [review]:

Comment 3 User image Matt Brubeck (:mbrubeck) 2011-12-01 11:24:31 PST

Note You need to log in before you can comment on or make changes to this bug.