Closed Bug 706550 Opened 8 years ago Closed 8 years ago

Change Awesomescreen "All" tab to read "Top Sites"

Categories

(Firefox for Android :: General, defect, P4)

All
Android
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: ibarlow, Assigned: lucasr)

Details

Attachments

(1 file)

Our start page UI has a section called Top Sites which pulls pages from our "all" awesomescreen list. They should probably be called the same thing, and "Top Sites" is actually a clearer explanation of what that list contains.
(In reply to Ian Barlow (:ibarlow) from comment #0)
> Our start page UI has a section called Top Sites which pulls pages from our
> "all" awesomescreen list. They should probably be called the same thing, and
> "Top Sites" is actually a clearer explanation of what that list contains.

Makes sense. However, I wonder if this is a good term to use if we take translations into account. For instance, I can't think of a good enough Portuguese translation for "Top Sites" in the UI. But maybe it's just because I'm not a good translator :-)
Assignee: nobody → lucasr.at.mozilla
OS: Mac OS X → Android
Hardware: x86 → All
It would be great to put it in front of our translators first to see. 

We can always fall back to "All" later if "Top Sites" becomes too much of a challenge to localize.
Attachment #578277 - Flags: review?(mark.finkle)
Priority: -- → P4
Comment on attachment 578277 [details] [diff] [review]
Rename "All Sites" tab to "Top Sites" in AwesomeBar

I'm going to give you a pass for now, since I don't think any l10n is happening yet. But in the future, we need to change the entity name (awesomebar_all_pages_title) in the DTD file. We can keep the entity name the same in the strings.xml file, but the l10n tools use the entity name to check for changes to the strings.
Attachment #578277 - Flags: review?(mark.finkle) → review+
Pushed: http://hg.mozilla.org/projects/birch/rev/be1d5acaffed
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Retested bug with:
Mozilla/5.0 (Android; Linux arm7l; rv:11.0a1) Gecko/20111205 Firefox/11.0a1 Fennec/11.0a1
Device: HTC Desire Z (Android 2.3)

"Top sites" is displayed instead of "All" tab.

Verifying bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.