Comment 1 Justin Lebar (not reading bugmail) 2011-11-30 12:13:22 PST

Comment on attachment 578035 [details] [diff] [review]
Handle no default in gonk key dispatching

> +    event.flags |= flags;

It would be clearer to do |event.flags = flags|.  Unless event.flags may be non-zero at this point?

For my edification, exactly what problem does this fix?  Is it that if you cancel the keydown, we shouldn't send the keypress?

btw, can you please set git to use more context for diffs?  (Bonus points for using --patience.)

Comment 2 Michael Wu [:mwu] 2011-12-02 10:02:06 PST

(In reply to Justin Lebar [:jlebar] from comment #1)
> Comment on attachment 578035 [details] [diff] [review] [diff] [details] [review]
> Handle no default in gonk key dispatching
> 
> > +    event.flags |= flags;
> 
> It would be clearer to do |event.flags = flags|.  Unless event.flags may be
> non-zero at this point?
> 

It is set to NS_EVENT_FLAG_TRUSTED.

> For my edification, exactly what problem does this fix?  Is it that if you
> cancel the keydown, we shouldn't send the keypress?
> 

Something like that. I don't remember the details, but it's the right thing to do and all the widget backends should be doing it.

Comment 3 Philipp von Weitershausen [:philikon] 2011-12-12 14:46:13 PST

This patch has review and still applies to m-c. Unless there are any objections, I will land this.

Comment 4 Michael Wu [:mwu] 2011-12-13 10:56:23 PST

https://hg.mozilla.org/mozilla-central/rev/16d41bf6df46