706698 - [dev] Unable to vouch for Mozillian accounts with newly vouched accounts

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Matt Brandt [:mbrandt]]

I am unable to find and vouch for a newly created account. This may be a duplicate of bug 704194.

Steps to reproduce:
1. create a new and un-vouched account
2. in a vouched account, go to the vouching url for the un-vouched profile also try searching for this account using the search field.

Actual:
Going to the vouch url produces at 404. Searching for the users account with their email returns zero results.

Expected:
The account should be findable and vouchable

Example account, newly minted on dev:
user: [e-mail]
vouch url: https://mozillians-dev.allizom.org/en-US/u/3de39af17e

Comment 1

[tofumatt [:tofumatt]]

I just vouched it ok. Though it's not SHOWING me as the voucher.

Comment 2

[Matt Brandt [:mbrandt]]

So I continued the quest to dig. This is subtle, the bug exists only if the vouched account is newly minted. 

On older accounts that have been vouched and in existence for awhile (I can't define *awhile*) locating and vouching for the account occurs as expected.

http://screencast.com/t/bIdiOai4

Comment 3

[Aakash Desai [:aakashd]]

This seems more like an issue for the non-vouched search piece of functionality. Thoughts, Jenn?

Comment 4

[Jen Fong-Adwent [:ednapiranha]]

Sounds like LDAP and MySQL are out of sync with each other on dev? Searches happen on the LDAP end for the user's vouched/nonvouched record but then we do a search on MySQL to filter groups. If these two databases are out of sync with each other, the former may return true and the latter false or vice versa.

Comment 6

[Austin King [:ozten]]

I created un-vouched user https://mozillians-dev.allizom.org/en-US/u/2a015d23a9 with [e-mail]

I logged in with my "staff" account ozten mozilla com.

I see a 404.

Using other accounts, the behavior works as expected.

I've deleted all traces of ozten mozilla com, since this was a duplicate admin account.

I then sign-ed up with ozten mozilla com. The 404 still repros.

Digging deeper...

Comment 7

[Austin King [:ozten]]

This repros in stage for my ozten mozilla com email address.

It didn't my first time through, so I deleted my account, re-registered, then tried the steps.

ISE for search 'a'.

ISE for viewing https://mozillians.allizom.org/en-US/u/f08d76e9e9

(Aside, I didn't automatically get 'staff' group in stage, but maybe that is a 1.2 feature)

Comment 8

[Austin King [:ozten]]

(In reply to Austin King [:ozten] from comment #7)
This repro's in production. All of the same steps as Comment#7.

Comment 9

[Austin King [:ozten]]

(In reply to Austin King [:ozten] from comment #8)

My hunch is that these accounts are vouched in MySQL and un-vouched in LDAP.
The 404 and ISE on uid are caused because the "staff" user doesn't have the right to view anyone but themselves.

If this holds, then fixing Bug#712085 fixed half the problem. The other half might be that auto-vouching based on domain name doesn't set a vouched by in LDAP.

I'll keep digging.

Comment 10

[Austin King [:ozten]]

Bug#81106#c13 has more findings.

Comment 11

[tofumatt [:tofumatt]]

Any accounts on dev are still affected. I can write a cron script if we see
this behaviour a lot in dev. It should be relatively easy to write. Let me know if it's needed.

Comment 12

[[github robot]]

Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/929236e304564137ed6e4726f7771c0d24aa7917
Vouch staff users in LDAP (fix bug 706698)

This should fix the issues we ran into where:

  1. staff users weren't vouched in LDAP
  2. them vouching other users became worthless
  3. you can see how that keeps going and means sucky data

Comment 13

[Matt Brandt [:mbrandt]]

Re-opened, my mbrandt staff account is unable to vouchify. It may be related to comment 12.

Comment 14

[tofumatt [:tofumatt]]

Should be re-fixed.

Comment 15

[Matt Brandt [:mbrandt]]

Sorry, this still appears to not work.

I just created a new unvouched non-staff account: 
 - [e-mail]
 - https://mozillians-dev.allizom.org/en-US/u/2a3e35a499

When using my staff account:
 - visting https://mozillians-dev.allizom.org/en-US/u/2a3e35a499 returns
   [13:01:15.677] GET https://mozillians-dev.allizom.org/en-US/u/2a3e35a499 [HTTP/1.1 404 NOT FOUND 428ms]
 - doing a search returns zero results
   [13:02:13.732] GET https://mozillians-dev.allizom.org/en-US/search?q=b506641%40nwldx.com [HTTP/1.1 200 OK 296ms]

Comment 16

[tofumatt [:tofumatt]]

I think I was using the wrong UID for staff people. This should work now. I added a cron script to fix any users that were broken.

Comment 17

[Matt Brandt [:mbrandt]]

QA verified on Dev. Vouching a new user works. Paths tested include using the apps search function (username & email address) and following the users vouch url.

Verified with the following accounts:
- With an old vouched non-staff
- With a staff account 
- With a newly minted vouched account