706794 - Add extensions.strictCompatibility pref to Thunderbird to make addons compatible-by-default

Status: RESOLVED FIXED

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #698653 +++

Firefox have done this on trunk builds, and I think we should do the same to help testing and get our confidence up.

We should also add the pref on aurora but set to disable add-ons by default, so we have the pref there should it need to be flipped, or testers want to flip it.

Comment 1

[Mark Banner (:standard8)]

Created attachment 578264 [details] [diff] [review]
The fix

Mainly looking for an rs here. I tested with an extension that is out of date wrt trunk, and it the add-on manager did the expected with this pref.

Comment 2

[Mark Banner (:standard8)]

Created attachment 578268 [details] [diff] [review]
Aurora fix

For now, keep strict compatibility turned on on earlybird.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 578268 [details] [diff] [review]
Aurora fix

Review of attachment 578268 [details] [diff] [review]:
-----------------------------------------------------------------

So…  Why do we want strict compatibility in Aurora?  Just cause that's what we currently do, and we don't want to change that behaviour until we've done some more testing?

(r=me with that question answered.)

Comment 4

[Mark Banner (:standard8)]

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #3)
> Comment on attachment 578268 [details] [diff] [review] [diff] [details] [review]
> Aurora fix
> 
> Review of attachment 578268 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> So…  Why do we want strict compatibility in Aurora?  Just cause that's what
> we currently do, and we don't want to change that behaviour until we've done
> some more testing?

That's what FF currently does. I believe they don't want it there just yet until they've done more testing.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 578264 [details] [diff] [review]
The fix

Review of attachment 578264 [details] [diff] [review]:
-----------------------------------------------------------------

WFM!

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/e946196ad328

Comment 7

[Mark Banner (:standard8)]

Landed on aurora: http://hg.mozilla.org/releases/comm-aurora/rev/bf785218e72c

Comment 8

[Mark Banner (:standard8)]

We now need to land setting the pref to false on beta, so cancelling the fixed flag so we can check that.

Comment 9

[Justin Wood (:Callek)]

(In reply to Mark Banner (:standard8) from comment #8)
> We now need to land setting the pref to false on beta, so cancelling the
> fixed flag so we can check that.

My QA checks caught this bug [x.ref https://wiki.mozilla.org/Releases/SeaMonkey2.7#Bug_Queries], out of curiosity, why are we backout out the pref? (what did I miss along the way?)

Comment 10

[Mark Banner (:standard8)]

(In reply to Justin Wood (:Callek) from comment #9)
> (In reply to Mark Banner (:standard8) from comment #8)
> > We now need to land setting the pref to false on beta, so cancelling the
> > fixed flag so we can check that.
> 
> My QA checks caught this bug [x.ref
> https://wiki.mozilla.org/Releases/SeaMonkey2.7#Bug_Queries], out of
> curiosity, why are we backout out the pref? (what did I miss along the way?)

I didn't say anything about backing out. I said we need to set the pref to false - if you look at what was landed, the pref is currently true.

Comment 11

[Justin Wood (:Callek)]

(In reply to Mark Banner (:standard8) from comment #10)
> (In reply to Justin Wood (:Callek) from comment #9)
> > (In reply to Mark Banner (:standard8) from comment #8)
> > > We now need to land setting the pref to false on beta, so cancelling the
> > > fixed flag so we can check that.
> > 
> > My QA checks caught this bug [x.ref
> > https://wiki.mozilla.org/Releases/SeaMonkey2.7#Bug_Queries], out of
> > curiosity, why are we backout out the pref? (what did I miss along the way?)
> 
> I didn't say anything about backing out. I said we need to set the pref to
> false - if you look at what was landed, the pref is currently true.

Ooooo right, the boolean logic in my head flipped when I commented here. Thanks

Comment 12

[Mark Banner (:standard8)]

Created attachment 586212 [details] [diff] [review]
The fix

Firefox enabled this on aurora, which is now beta after the merge, hence we should do this on beta as its better for extensions.

Comment 13

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/releases/comm-beta/rev/308536744457