Closed Bug 706844 Opened 8 years ago Closed 8 years ago

Create a make target for peptest

Categories

(Testing Graveyard :: Peptest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla11

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(2 files, 2 obsolete files)

No description provided.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
This patch also includes some updates to mozbase that was required to get importing from directories working
Attachment #578618 - Flags: review?(jmaher)
Comment on attachment 578618 [details] [diff] [review]
Patch 1.0 - Make target for peptest

Review of attachment 578618 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/testsuite-targets.mk
@@ +232,5 @@
>  
> +RUN_PEPTEST = \
> +	rm -f ./$@.log && \
> +	$(PYTHON) _tests/peptest/runtests.py --binary=$(browser_path) $(PEPTEST_PATH_ARG) \
> +	  --log-file=./$@.log $(SYMBOLS_PATH) $(EXTRA_TEST_ARGS)

I would like to see a link to a wiki with what extra_test_args can be for peptests.
Attachment #578618 - Flags: review?(jmaher) → review+
Attachment #578618 - Attachment is obsolete: true
make[5]: Entering directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/peptest'
/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/config/nsinstall -R /home/jmaher/mozilla/inbound/testing/peptest/peptest ../../_tests/peptest
/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/config/nsinstall -R /home/jmaher/mozilla/inbound/testing/peptest/setup.py /home/jmaher/mozilla/inbound/testing/peptest/runtests.py /home/jmaher/mozilla/inbound/testing/peptest/MANIFEST.in /home/jmaher/mozilla/inbound/testing/peptest/README.md ../../_tests/peptest
/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/config/nsinstall -R /home/jmaher/mozilla/inbound/testing/peptest/tests ../../_tests/peptest
make[5]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/peptest'
make -C testing/mozbase libs
make[5]: Entering directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/mozbase'
make[5]: *** No rule to make target `mozdevice', needed by `libs'.  Stop.
make[5]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/mozbase'
make[4]: *** [libs_tier_platform] Error 2
make[4]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu'
make[3]: *** [tier_platform] Error 2
make[3]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu'
make[1]: *** [realbuild] Error 2
make[1]: Leaving directory `/home/jmaher/mozilla/inbound'
make: *** [build] Error 2
jmaher@jmaher-ubuntu-mbp:~/mozilla/inbound$
Sorry about that. I had mozdevice in my local file system but didn't hg add it (since nothing used it anyway) and so didn't run into this. This patch just adds mozdevice since it will be needed later on anyway.
Attachment #578660 - Attachment is obsolete: true
Now it breaks windows builds:
https://tbpl.mozilla.org/?tree=Try&rev=d4c801274181

make[1]: Leaving directory `/e/builds/moz2_slave/try-w32-dbg/build'
nsinstall: e:\builds\moz2_slave\try-w32-dbg\build\testing\peptest\peptest is a directory
make[5]: *** [libs] Error 3
make[4]: *** [libs_tier_platform] Error 2
make[3]: *** [tier_platform] Error 2
make[2]: *** [default] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2
program finished with exit code 2
nsinstall can't recursively copy directories on Windows.  You want to use nsinstall.py

e.g. http://mxr.mozilla.org/mozilla-central/source/services/crypto/Makefile.in#49
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #7)
> nsinstall can't recursively copy directories on Windows.  You want to use
> nsinstall.py
> 
> e.g.
> http://mxr.mozilla.org/mozilla-central/source/services/crypto/Makefile.in#49

Ah ok, I was going to say that I just copied Mochitest, but then realized that Mochitest explicitly lists every file they're copying. Thanks!
Attached patch Patch 1.3 (inc)Splinter Review
Simple incremental fix. I don't have a Windows environment I can test on, Joel can you do another try run for me please?
https://hg.mozilla.org/mozilla-central/rev/65c05ff60e47
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.