706844 - Create a make target for peptest

Status: RESOLVED FIXED

(Testing Graveyard :: Peptest, defect)

Comment 1

[Andrew Halberstadt [:ahal] (PTO until Oct 10th)]

Attachment: Patch 1.0 - Make target for peptest

This patch also includes some updates to mozbase that was required to get importing from directories working

Comment 2

[Joel Maher ( :jmaher ) (UTC -0800)]

Comment on attachment 578618 [details] [diff] [review]
Patch 1.0 - Make target for peptest

Review of attachment 578618 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/testsuite-targets.mk
@@ +232,5 @@
>  
> +RUN_PEPTEST = \
> +	rm -f ./$@.log && \
> +	$(PYTHON) _tests/peptest/runtests.py --binary=$(browser_path) $(PEPTEST_PATH_ARG) \
> +	  --log-file=./$@.log $(SYMBOLS_PATH) $(EXTRA_TEST_ARGS)

I would like to see a link to a wiki with what extra_test_args can be for peptests.

Comment 3

[Andrew Halberstadt [:ahal] (PTO until Oct 10th)]

Attachment: Patch 1.1 - Includes link to wiki

Comment 4

[Joel Maher ( :jmaher ) (UTC -0800)]

make[5]: Entering directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/peptest'
/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/config/nsinstall -R /home/jmaher/mozilla/inbound/testing/peptest/peptest ../../_tests/peptest
/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/config/nsinstall -R /home/jmaher/mozilla/inbound/testing/peptest/setup.py /home/jmaher/mozilla/inbound/testing/peptest/runtests.py /home/jmaher/mozilla/inbound/testing/peptest/MANIFEST.in /home/jmaher/mozilla/inbound/testing/peptest/README.md ../../_tests/peptest
/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/config/nsinstall -R /home/jmaher/mozilla/inbound/testing/peptest/tests ../../_tests/peptest
make[5]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/peptest'
make -C testing/mozbase libs
make[5]: Entering directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/mozbase'
make[5]: *** No rule to make target `mozdevice', needed by `libs'.  Stop.
make[5]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/mozbase'
make[4]: *** [libs_tier_platform] Error 2
make[4]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu'
make[3]: *** [tier_platform] Error 2
make[3]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu'
make[1]: *** [realbuild] Error 2
make[1]: Leaving directory `/home/jmaher/mozilla/inbound'
make: *** [build] Error 2
jmaher@jmaher-ubuntu-mbp:~/mozilla/inbound$

Comment 5

[Andrew Halberstadt [:ahal] (PTO until Oct 10th)]

Attachment: Patch 1.2 - Fix mozdevice issue

Sorry about that. I had mozdevice in my local file system but didn't hg add it (since nothing used it anyway) and so didn't run into this. This patch just adds mozdevice since it will be needed later on anyway.

Comment 6

[Andrew Halberstadt [:ahal] (PTO until Oct 10th)]

Now it breaks windows builds:
https://tbpl.mozilla.org/?tree=Try&rev=d4c801274181

make[1]: Leaving directory `/e/builds/moz2_slave/try-w32-dbg/build'
nsinstall: e:\builds\moz2_slave\try-w32-dbg\build\testing\peptest\peptest is a directory
make[5]: *** [libs] Error 3
make[4]: *** [libs_tier_platform] Error 2
make[3]: *** [tier_platform] Error 2
make[2]: *** [default] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2
program finished with exit code 2

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

nsinstall can't recursively copy directories on Windows.  You want to use nsinstall.py

e.g. http://mxr.mozilla.org/mozilla-central/source/services/crypto/Makefile.in#49

Comment 8

[Andrew Halberstadt [:ahal] (PTO until Oct 10th)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #7)
> nsinstall can't recursively copy directories on Windows.  You want to use
> nsinstall.py
> 
> e.g.
> http://mxr.mozilla.org/mozilla-central/source/services/crypto/Makefile.in#49

Ah ok, I was going to say that I just copied Mochitest, but then realized that Mochitest explicitly lists every file they're copying. Thanks!

Comment 9

[Andrew Halberstadt [:ahal] (PTO until Oct 10th)]

Attachment: Patch 1.3 (inc)

Simple incremental fix. I don't have a Windows environment I can test on, Joel can you do another try run for me please?

Comment 10

[Andrew Halberstadt [:ahal] (PTO until Oct 10th)]

Nothing related to this patch: https://tbpl.mozilla.org/?tree=Try&rev=803562ead35b

Comment 11

[Joel Maher ( :jmaher ) (UTC -0800)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65c05ff60e47

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/65c05ff60e47