Closed
Bug 706844
Opened 9 years ago
Closed 9 years ago
Create a make target for peptest
Categories
(Testing Graveyard :: Peptest, defect)
Testing Graveyard
Peptest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla11
People
(Reporter: ahal, Assigned: ahal)
Details
Attachments
(2 files, 2 obsolete files)
243.46 KB,
patch
|
Details | Diff | Splinter Review | |
1.85 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
This patch also includes some updates to mozbase that was required to get importing from directories working
Assignee | ||
Updated•9 years ago
|
Attachment #578618 -
Flags: review?(jmaher)
Comment 2•9 years ago
|
||
Comment on attachment 578618 [details] [diff] [review] Patch 1.0 - Make target for peptest Review of attachment 578618 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/testsuite-targets.mk @@ +232,5 @@ > > +RUN_PEPTEST = \ > + rm -f ./$@.log && \ > + $(PYTHON) _tests/peptest/runtests.py --binary=$(browser_path) $(PEPTEST_PATH_ARG) \ > + --log-file=./$@.log $(SYMBOLS_PATH) $(EXTRA_TEST_ARGS) I would like to see a link to a wiki with what extra_test_args can be for peptests.
Attachment #578618 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #578618 -
Attachment is obsolete: true
Comment 4•9 years ago
|
||
make[5]: Entering directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/peptest' /home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/config/nsinstall -R /home/jmaher/mozilla/inbound/testing/peptest/peptest ../../_tests/peptest /home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/config/nsinstall -R /home/jmaher/mozilla/inbound/testing/peptest/setup.py /home/jmaher/mozilla/inbound/testing/peptest/runtests.py /home/jmaher/mozilla/inbound/testing/peptest/MANIFEST.in /home/jmaher/mozilla/inbound/testing/peptest/README.md ../../_tests/peptest /home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/config/nsinstall -R /home/jmaher/mozilla/inbound/testing/peptest/tests ../../_tests/peptest make[5]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/peptest' make -C testing/mozbase libs make[5]: Entering directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/mozbase' make[5]: *** No rule to make target `mozdevice', needed by `libs'. Stop. make[5]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu/testing/mozbase' make[4]: *** [libs_tier_platform] Error 2 make[4]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu' make[3]: *** [tier_platform] Error 2 make[3]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu' make[2]: *** [default] Error 2 make[2]: Leaving directory `/home/jmaher/mozilla/inbound/obj-i686-pc-linux-gnu' make[1]: *** [realbuild] Error 2 make[1]: Leaving directory `/home/jmaher/mozilla/inbound' make: *** [build] Error 2 jmaher@jmaher-ubuntu-mbp:~/mozilla/inbound$
Assignee | ||
Comment 5•9 years ago
|
||
Sorry about that. I had mozdevice in my local file system but didn't hg add it (since nothing used it anyway) and so didn't run into this. This patch just adds mozdevice since it will be needed later on anyway.
Attachment #578660 -
Attachment is obsolete: true
Assignee | ||
Comment 6•9 years ago
|
||
Now it breaks windows builds: https://tbpl.mozilla.org/?tree=Try&rev=d4c801274181 make[1]: Leaving directory `/e/builds/moz2_slave/try-w32-dbg/build' nsinstall: e:\builds\moz2_slave\try-w32-dbg\build\testing\peptest\peptest is a directory make[5]: *** [libs] Error 3 make[4]: *** [libs_tier_platform] Error 2 make[3]: *** [tier_platform] Error 2 make[2]: *** [default] Error 2 make[1]: *** [realbuild] Error 2 make: *** [build] Error 2 program finished with exit code 2
nsinstall can't recursively copy directories on Windows. You want to use nsinstall.py e.g. http://mxr.mozilla.org/mozilla-central/source/services/crypto/Makefile.in#49
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #7) > nsinstall can't recursively copy directories on Windows. You want to use > nsinstall.py > > e.g. > http://mxr.mozilla.org/mozilla-central/source/services/crypto/Makefile.in#49 Ah ok, I was going to say that I just copied Mochitest, but then realized that Mochitest explicitly lists every file they're copying. Thanks!
Assignee | ||
Comment 9•9 years ago
|
||
Simple incremental fix. I don't have a Windows environment I can test on, Joel can you do another try run for me please?
Assignee | ||
Comment 10•9 years ago
|
||
Nothing related to this patch: https://tbpl.mozilla.org/?tree=Try&rev=803562ead35b
Comment 11•9 years ago
|
||
inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/65c05ff60e47
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/65c05ff60e47
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Updated•3 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•