706933 - xpidl.py dies on Windows/DOS EOL \r

Status: NEW

(Core :: XPCOM, defect)

Description

[David Humphrey (:humph)]

If an IDL file contains a DOS EOL, xpidl.py dies:

/usr/bin/python2.6 /home/dave/repos/mozilla-central/config/pythonpath.py \
          -I/home/dave/repos/mozilla-central/other-licenses/ply \
          -I/home/dave/repos/mozilla-central/xpcom/idl-parser \
          /home/dave/repos/mozilla-central/xpcom/idl-parser/header.py --cachedir=../../../xpcom/idl-parser -I/home/dave/repos/mozilla-central/js/xpconnect/idl -I../../../dist/idl /home/dave/repos/mozilla-central/js/xpconnect/idl/nsIJSEngineTelemetryStats.idl -d .deps/nsIJSEngineTelemetryStats.h.pp -o _xpidlgen/nsIJSEngineTelemetryStats.h
Traceback (most recent call last):
  File "/home/dave/repos/mozilla-central/config/pythonpath.py", line 52, in <module>
    main(sys.argv[1:])
  File "/home/dave/repos/mozilla-central/config/pythonpath.py", line 44, in main
    execfile(script, frozenglobals)
  File "/home/dave/repos/mozilla-central/xpcom/idl-parser/header.py", line 522, in <module>
    idl = p.parse(open(file).read(), filename=file)
  File "/home/dave/repos/mozilla-central/xpcom/idl-parser/xpidl.py", line 1478, in parse
    idl = self.parser.parse(lexer=self)
  File "/home/dave/repos/mozilla-central/other-licenses/ply/ply/yacc.py", line 265, in parse
    return self.parseopt_notrack(input,lexer,debug,tracking,tokenfunc)
  File "/home/dave/repos/mozilla-central/other-licenses/ply/ply/yacc.py", line 921, in parseopt_notrack
    lookahead = get_token()     # Get the next token
  File "/home/dave/repos/mozilla-central/xpcom/idl-parser/xpidl.py", line 1467, in token
    t = self.lexer.token()
  File "/home/dave/repos/mozilla-central/other-licenses/ply/ply/lex.py", line 384, in token
    newtok = self.lexerrorf(tok)
  File "/home/dave/repos/mozilla-central/xpcom/idl-parser/xpidl.py", line 1150, in t_ANY_error
    lexpos=self.lexer.lexpos))
xpidl.IDLError: error: unrecognized input, /home/dave/repos/mozilla-central/js/xpconnect/idl/nsIJSEngineTelemetryStats.idl line 1:79
/* -*- Mode: C++; c-basic-offset: 2; indent-tabs-mode: nil; tab-width: 8 -*- */
                                                                               ^
make[6]: *** [_xpidlgen/nsIJSEngineTelemetryStats.h] Error 1
make[6]: *** Deleting file `_xpidlgen/nsIJSEngineTelemetryStats.h'
make[6]: Leaving directory `/home/dave/repos/mozilla-central/objdir-debug/js/xpconnect/idl'
make[5]: *** [export] Error 2
make[5]: Leaving directory `/home/dave/repos/mozilla-central/objdir-debug/js/xpconnect'
make[4]: *** [export_tier_platform] Error 2
make[4]: Leaving directory `/home/dave/repos/mozilla-central/objdir-debug'
make[3]: *** [tier_platform] Error 2
make[3]: Leaving directory `/home/dave/repos/mozilla-central/objdir-debug'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/home/dave/repos/mozilla-central/objdir-debug'
make[1]: *** [realbuild] Error 2
make[1]: Leaving directory `/home/dave/repos/mozilla-central'
make: *** [build] Error 2

I think it should be able to survive this; but if others disagree, then at least an error message that makes clear what the issue really is.