Last Comment Bug 707061 - Rename js_ValueToString as js::ToString, and make check-for-string-inline the default
: Rename js_ValueToString as js::ToString, and make check-for-string-inline the...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla11
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-01 19:35 PST by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-12-07 12:27 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (32.36 KB, patch)
2011-12-01 19:35 PST, Jeff Walden [:Waldo] (remove +bmo to email)
luke: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2011-12-01 19:35:01 PST
Created attachment 578480 [details] [diff] [review]
Patch

Spec uses ToString, we should too -- it's nicer to read, to boot.  I also went through all js_ValueToString uses and converted them to ToString if their argument might be a string and ToStringSlow if it definitely wasn't.
Comment 1 Luke Wagner [:luke] 2011-12-02 08:22:31 PST
Comment on attachment 578480 [details] [diff] [review]
Patch

Nice.

>-             JSString *str = js_ValueToString(cx, Int32Value(JSID_TO_INT(id)));
>+             JSString *str = js_IntToString(cx, JSID_TO_INT(id));

Hah.  What's js_ doing in front of IntToString...
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2011-12-07 08:58:17 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4ac6e1958e8
Comment 3 Matt Brubeck (:mbrubeck) 2011-12-07 12:27:23 PST
https://hg.mozilla.org/mozilla-central/rev/d4ac6e1958e8

Note You need to log in before you can comment on or make changes to this bug.