Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Rename js_ValueToString as js::ToString, and make check-for-string-inline the default

RESOLVED FIXED in mozilla11

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 578480 [details] [diff] [review]
Patch

Spec uses ToString, we should too -- it's nicer to read, to boot.  I also went through all js_ValueToString uses and converted them to ToString if their argument might be a string and ToStringSlow if it definitely wasn't.
Attachment #578480 - Flags: review?(luke)

Comment 1

6 years ago
Comment on attachment 578480 [details] [diff] [review]
Patch

Nice.

>-             JSString *str = js_ValueToString(cx, Int32Value(JSID_TO_INT(id)));
>+             JSString *str = js_IntToString(cx, JSID_TO_INT(id));

Hah.  What's js_ doing in front of IntToString...
Attachment #578480 - Flags: review?(luke) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4ac6e1958e8
https://hg.mozilla.org/mozilla-central/rev/d4ac6e1958e8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.