Closed Bug 707061 Opened 8 years ago Closed 8 years ago

Rename js_ValueToString as js::ToString, and make check-for-string-inline the default

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Spec uses ToString, we should too -- it's nicer to read, to boot.  I also went through all js_ValueToString uses and converted them to ToString if their argument might be a string and ToStringSlow if it definitely wasn't.
Attachment #578480 - Flags: review?(luke)
Comment on attachment 578480 [details] [diff] [review]
Patch

Nice.

>-             JSString *str = js_ValueToString(cx, Int32Value(JSID_TO_INT(id)));
>+             JSString *str = js_IntToString(cx, JSID_TO_INT(id));

Hah.  What's js_ doing in front of IntToString...
Attachment #578480 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/d4ac6e1958e8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.