707136 - Knowledge base article preview button does not work

Status: VERIFIED FIXED

(support.mozilla.org :: Code Quality, task)

Description

[Zac C (:zac)]

'Preview Content' button is not working.

See example page: 
https://support-dev.allizom.org/en-US/kb/kjhkjlhklh/edit/16691

Does nothing and no error messages.

Comment 1

[James Socol [:jsocol, :james]]

Zac, does this also occur on support.allizom.org, or just -dev?

wiki.js, line 448, syntax error.

-dev also appears to be serving unminified scripts. Need to work with Jason to fix that.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to James Socol [:jsocol, :james] from comment #1)
> Zac, does this also occur on support.allizom.org, or just -dev?
> 
> wiki.js, line 448, syntax error.
> 
> -dev also appears to be serving unminified scripts. Need to work with Jason
> to fix that.

Looks like just -dev; our sumo.release job is using the same codebase, and is passing: http://qa-selenium.mv.mozilla.com:8080/job/sumo.release/

Additionally, was it intentional to remove the button's ID?  We did a band-aid patch here, to fix our tests, but I'd rather we used an ID: https://github.com/mozilla/sumo-tests/commit/a953e18163d7cc1e0847b6ca14625086240f642d

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

JS error. Looks like possibly a merge issue.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Stephen Donner [:stephend] from comment #2)
> Additionally, was it intentional to remove the button's ID?
We have the button twice on the page now which is why we removed the ID (but missed the other html part with ID being on the page twice). I would feel dirty having an id-1 and id-2 or something like that if it isn't necessary :-)

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

<3 Automation. This was potentially a hot fix waiting to happen. Our js tests would have caught this too but we had them temporarily disabled.

Fixed in https://github.com/jsocol/kitsune/commit/2909abb55e4cfaa6246bc29b0283d2a52ae73d5e

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Zac, please verify this when you get a chance; thanks!  (I know the automation passed, but would be nice to have manual verification too.)

Comment 7

[Rebecca Billings [:rbillings]]

https://support-dev.allizom.org/en-US/kb/adventure/edit

* The page displays two sets of preview/submit buttons, and neither works

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Cached scripts?

Comment 9

[Rebecca Billings [:rbillings]]

Verified it was a cache issue, preview button does work on -dev