707197 - Send weekly OF reports to dev-tree-management newsgroup

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect)

Description

[Mark Côté [:mcote]]

The weekly OF report only goes to the dev-tree-management mailing list and doesn't show up in the newsgroup.  It should use NNTP to post directly to the group.

Comment 1

[Mark Côté [:mcote]]

Attachment: NNTP support

This adds NNTP support. You can now specify destination email addresses and/or
newsgroups.  I moved the username option into report/from so that it'll be
used by both email and NNTP.

Comment 2

[Mark Côté [:mcote]]

Attachment: NNTP support

Oops, broke email there.  Since technically the username for email (for authenticated email) may be different from the From header, I put the email/username option back in but made it optional.

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 585542 [details] [diff] [review]
NNTP support

Review of attachment 585542 [details] [diff] [review]:
-----------------------------------------------------------------

Yay, newsgroup support!

::: woo_mailer.py
@@ +127,5 @@
>      try:
>          mail_username = cfg.get('email', 'username')
>      except (ConfigParser.NoSectionError, ConfigParser.NoOptionError):
> +        mail_username = None
> +

Possibly this should be:

if mail_dest:
    sys.stderr.write('No "username" option defined in "email" section of file "%s".' % options.config_file)
    sys.exit(errno.EINVAL)
else:
    mail_username = None

Or are there cases where this could validly be None when sending e-mail?

Comment 4

[Mark Côté [:mcote]]

mail_username is (now) only used for email authentication, along with mail_password.  Since brasstacks is behind a firewall, on the Mozilla network, the woo mailer has always been using plain SMTP.  It was only using mail_username for the From: header, which I moved to another section to share it with the NNTP config.  So yes, perfectly fine for it to be None now. :)

Pushed as http://hg.mozilla.org/automation/orangefactor/rev/63cc26e54206 and deployed.  Ran it immediately to send email and post to newsgroup, which worked perfectly.  Remind me to check this next Tuesday. ;)

Comment 5

[(no longer active)]

Would you mind announcing this on dev.platform please?  :-)

Comment 6

[Mark Côté [:mcote]]

Done! :)