70731 - CVS account request

Status: VERIFIED FIXED

(mozilla.org :: Repository Account Requests, task)

Description

[Håkan Waara]

I would like to get a CVS account. I've been involved with, mostly mailnews, but
also other parts of the Mozilla project. I'm cc'ing some Mailnews people that
(hopefully) has noticed my contribution and some others that have been helping
me and which I've been in touch with since day one.

I started out with very easy, wording changes, and now I certainly am on another
level so it would be nice if I could also get my own checkin rights. Below is a
link to most of the bugs I have fixed.

http://bugzilla.mozilla.org/buglist.cgi?email1=&emailtype1=substring&emailassigned_to1=1&email2=&emailtype2=substring&emailreporter2=1&bugidtype=include&bug_id=64291%2C+43675%2C+55887%2C+62703%2C+50328%2C+54492%2C+63122%2C+65019%2C+59327%2C+60788%2C+64473%2C+64171%2C+65076%2C+67245%2C+41402%2C+61830%2C+68365%2C+70312%2C+58085%2C+68525&changedin=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&short_desc=&short_desc_type=substring&long_desc=&long_desc_type=substring&bug_file_loc=&bug_file_loc_type=substring&status_whiteboard=&status_whiteboard_type=substring&keywords=&keywords_type=anywords&field0-0-0=noop&type0-0-0=noop&value0-0-0=&cmdtype=doit&newqueryname=&order=Bug+Number

Thanks for your time!

Comment 1

[David :Bienvenu]

I'll vouch for Håkan - he has made frequent contributions.

Comment 2

[Blake Ross]

Not to direct this specifically at this request, but (having seen a couple 
requests for levels of cvs access recently...wording changes, fe, etc.) I'm 
wondering if it's time to either modify the cvs write access approval rules to 
be less stringent or create (or formalize, at least) access levels.

I ask because I keep seeing the formal rules at 
http://mozilla.org/hacking/getting-cvs-write-access.html get broken (not using 
at least one non-netscape superreview, no questions about or demonstration of 
knowledge of any of the topics under `Super-Review Content'.)

The justification for glossing over the knowledge rule is typically that the 
requestor only wants to work on things that don't require such knowledge (and 
that's certainly understandable...I don't think it's fair to ask a themes 
person about xpcom).  But I don't think it makes sense to give people access to 
the entire tree just because, at the time of their account request, they had a 
narrow idea of what they wanted to work on, and made a verbal, usually 
noncommittal agreement that they'd stay within those bounds.  As people learn 
more, they may want to get more involved with xpidl, xpcom, c++, etc., and it 
will be possible for them to check in such changes using the cvs account they 
acquired based solely on some wording changes they made months earlier.

Basically I've been seeing a lot of special-casing going on and just think that 
we need to handle these common cases in the rules.  Again, this isn't a 
reference to this specific request; just throwing this out for discussion in 
response to some recent account requests I've seen).

Comment 3

[Jean-Francois Ducarroz]

I give him my support. He does helpfull contribution...

Comment 4

[Marcia Knous [:marcia]]

I have not yet received a CVS access form from hwaara - will need it to proceed.

Comment 5

[(not reading, please use [e-mail] instead)]

yes, hwaara has been doing some good patches.  no reason he shouldn't be able to
check them in once they go through the proper review / super review process.

Comment 6

[timeless]

hwaara's patches are good

Comment 7

[Håkan Waara]

Marcia Knous has gotten the info she needed. I need 3 super-reviews in order to
get CVS write access. Come on now guys :)

Comment 8

[David :Bienvenu]

do you just need one more? you've got me and seth.

Comment 9

[Håkan Waara]

I guess so. I don't know who to ask though, as most of my contribution and focus
will and has gone to Mailnews.

CC'ing mscott in case he agrees with bienvenu and sspitzer.

Comment 10

[Håkan Waara]

To add to the list I attached when I submitted this bug, this is some new bugs
I've fixed in the past few days:

bug 67108 - "Mail startpage" groupbox needs cleanup
bug 69256 - nsMsgNewsFolder::UpdateSummaryFromNNTPInfo leaks nsMsgKeySet
bug 71024 - crash on MSGNEWS.DLL when you rapidly select different messages

Please, is there any super-reviewer left who can consider giving me my (last)
sr= in order to get access?    Thanks!

Comment 11

[Mike Shaver (:shaver emeritus)]

Håkan's work is pretty solid, and he seems to understand and respect Mozilla's
``house rules''.  In addition, he's proven responsive to module-owner
preferences, which is always important.

I'll be your third super-reviewer, with pleasure.  Welcome to the club!

Comment 12

[Marcia Knous [:marcia]]

Activating account 3/9/01, as Hakan has a voucher as well as 3 srs.

Comment 13

[Marcia Knous [:marcia]]

Resolving bug to fixed as account has been activated.

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

Verified, I've witnessed him checking into the CVS repository.