Closed Bug 707315 Opened 9 years ago Closed 9 years ago

Add bottom border to the views

Categories

(Calendar :: Calendar Views, defect)

Lightning 1.3
All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

With landing of Bug 677882 the views needs now bottom borders to look like the three pane view of TB.
Attached patch Add the bordersSplinter Review
This patch simply gives the borders.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #578717 - Flags: ui-review?(nisses.mail)
Attachment #578717 - Flags: review?(philipp)
Comment on attachment 578717 [details] [diff] [review]
Add the borders

r=philipp codewise. Is this linux only, or needed on other platforms?
Attachment #578717 - Flags: review?(philipp) → review+
Yes this is Linux only. The other platforms statusbars have a top border and Linux not.
@paenglab: Is this checkin-needed?
(In reply to Martin Schröder [:mschroeder] from comment #4)
> @paenglab: Is this checkin-needed?

No, it is still ui-r=? by Andreas.
Comment on attachment 578717 [details] [diff] [review]
Add the borders

Looks good!
ui-r+
Attachment #578717 - Flags: ui-review?(nisses.mail) → ui-review+
Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/b425904a629f>
Target Milestone: --- → 1.4
Comment on attachment 578717 [details] [diff] [review]
Add the borders

Philipp, do you give me approval for aurora? The TB patch which removed the borders is also in aurora.
Attachment #578717 - Flags: feedback?(philipp)
Comment on attachment 578717 [details] [diff] [review]
Add the borders

approval for aurora = yes
Attachment #578717 - Flags: feedback?(philipp) → feedback+
Pushed to comm-aurora: <http://hg.mozilla.org/releases/comm-aurora/rev/f9ec15220d70>
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: 1.4 → 1.3
You need to log in before you can comment on or make changes to this bug.