Closed Bug 707418 Opened 13 years ago Closed 13 years ago

config/mkdepend/Makefile should not be generated by default in js/src

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 707593

People

(Reporter: t.matsuu, Assigned: t.matsuu)

Details

Attachments

(1 file)

After m-c bbbe2010c4ba is checked in, config/mkdepend/Makefile is conditionally generated.

https://hg.mozilla.org/mozilla-central/rev/bbbe2010c4ba

So we now get the TEST-UNEXPECTED-FAIL error from check-sync-dirs.py.

error message:
TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
TEST-INFO | check-sync-dirs.py | file(s) found in:               /media/bkup/work/rpmbuild/BUILD/xulrunner-11.0/mozilla-central/js/src/config
TEST-INFO | check-sync-dirs.py | differ from their originals in: /media/bkup/work/rpmbuild/BUILD/xulrunner-11.0/mozilla-central/config
TEST-INFO | check-sync-dirs.py | differing file:                 ./mkdepend/Makefile
In general, the files in '/media/bkup/work/rpmbuild/BUILD/xulrunner-11.0
/mozilla-central/js/src/config' should always be exact copies of originals
in '/media/bkup/work/rpmbuild/BUILD/xulrunner-11.0/mozilla-central/config'.
A change made to one should also be made to the other.  See 'check-sync-
dirs.py' for more details.
Attached patch FixSplinter Review
Attachment #578818 - Flags: review?(dmandelin)
Comment on attachment 578818 [details] [diff] [review]
Fix

I think Kyle is a much more qualified reviewer for this.
Attachment #578818 - Flags: review?(dmandelin) → review?(khuey)
Keywords: checkin-needed
Assignee: general → t.matsuu
Ah, this is fixed by bug 707593.
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: