Closed
Bug 707418
Opened 13 years ago
Closed 13 years ago
config/mkdepend/Makefile should not be generated by default in js/src
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 707593
People
(Reporter: t.matsuu, Assigned: t.matsuu)
Details
Attachments
(1 file)
827 bytes,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
After m-c bbbe2010c4ba is checked in, config/mkdepend/Makefile is conditionally generated. https://hg.mozilla.org/mozilla-central/rev/bbbe2010c4ba So we now get the TEST-UNEXPECTED-FAIL error from check-sync-dirs.py. error message: TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync TEST-INFO | check-sync-dirs.py | file(s) found in: /media/bkup/work/rpmbuild/BUILD/xulrunner-11.0/mozilla-central/js/src/config TEST-INFO | check-sync-dirs.py | differ from their originals in: /media/bkup/work/rpmbuild/BUILD/xulrunner-11.0/mozilla-central/config TEST-INFO | check-sync-dirs.py | differing file: ./mkdepend/Makefile In general, the files in '/media/bkup/work/rpmbuild/BUILD/xulrunner-11.0 /mozilla-central/js/src/config' should always be exact copies of originals in '/media/bkup/work/rpmbuild/BUILD/xulrunner-11.0/mozilla-central/config'. A change made to one should also be made to the other. See 'check-sync- dirs.py' for more details.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #578818 -
Flags: review?(dmandelin)
Comment 2•13 years ago
|
||
Comment on attachment 578818 [details] [diff] [review] Fix I think Kyle is a much more qualified reviewer for this.
Attachment #578818 -
Flags: review?(dmandelin) → review?(khuey)
Attachment #578818 -
Flags: review?(khuey) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Assignee: general → t.matsuu
Assignee | ||
Comment 3•13 years ago
|
||
Ah, this is fixed by bug 707593.
You need to log in
before you can comment on or make changes to this bug.
Description
•