Closed Bug 70750 Opened 24 years ago Closed 24 years ago

[XUL Syntax] Dialogs should use <dialog> instead of <window class="dialog">

Categories

(Core :: XUL, defect, P2)

x86
Other
defect

Tracking

()

RESOLVED FIXED
mozilla0.9.5

People

(Reporter: hyatt, Assigned: hewitt)

References

Details

(Whiteboard: [XUL1.0])

Attachments

(2 files)

Title is self-explanatory. We should use a different tag for a dialog than for a window.
Status: NEW → ASSIGNED
Whiteboard: [XUL1.0]
Depends on: 70753
No longer depends on: 70753
Blocks: 70753
<dialog> should also include a bunch of stuff "for free," such as OK and cancel buttons, keyboard handling associated with those buttons etc. Working on a binding for this at the moment, so taking.
Assignee: hyatt → ben
Status: ASSIGNED → NEW
making sure xul1.0 bugs are targeted to mozilla1.0.
Target Milestone: --- → mozilla1.0
I was thinking of asking for an enhancement to dialogs whereby Return or Enter clicks the focused button as it does in Windows. (This doesn't affect the Mac because buttons don't take focus on the Mac.) Will you be able to consider this?
yes, this was planned
A couple of queries here: In what form will you be able to filter the buttons: for example, say I want no buttons on my dialog or more than 2? When is the expected landing date for this change?
mine
Assignee: ben → hewitt
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: mozilla1.0 → mozilla0.9.5
Attached patch patch to fixSplinter Review
Please use the new MPL/NPL triple-license on all new files.
Attached patch updated patchSplinter Review
Three comments: <xul:vbox class="box-inherit dialog-content-box" flex="1"> ... inherit="align,dir,orient,pack" +var list = aButtons.split(/[, ]+/); -var list = aButtons.split(","); -if (list.length == 1) - list = aButtons.split(" "); var shown = { accept: false, cancel: false, help: false, disclosure: false}; for (var i = 0; i < list.length; ++i) - shown[list[i].replace(/ /g, "")] = true; + shown[list[i]] = true; \ No newline at end of file
Neil, the purpose of all that extra parsing code is to allow people to use comma OR space delimited lists, and to trim extra whitespace.
Blocks: 63728
fixed. I will open a new bug for moving all dialogs in the app to the new syntax.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: