70750 - [XUL Syntax] Dialogs should use <dialog> instead of <window class="dialog">

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[David Hyatt]

Title is self-explanatory.  We should use a different tag for a dialog than for
a window.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

<dialog> should also include a bunch of stuff "for free," such as OK and cancel 
buttons, keyboard handling associated with those buttons etc. 

Working on a binding for this at the moment, so taking. 

Comment 2

[David Hyatt]

making sure xul1.0 bugs are targeted to mozilla1.0.

Comment 3

[[e-mail]]

I was thinking of asking for an enhancement to dialogs whereby Return or Enter
clicks the focused button as it does in Windows. (This doesn't affect the Mac
because buttons don't take focus on the Mac.) Will you be able to consider this?

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

yes, this was planned

Comment 5

[Brian King [:kinger]]

A couple of queries here:
In what form will you be able to filter the buttons: for example, say I want no 
buttons on my dialog or more than 2?

When is the expected landing date for this change?

Comment 6

[Joe Hewitt (gone)]

mine

Comment 7

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 8

[Håkan Waara]

Please use the new MPL/NPL triple-license on all new files.

Comment 9

[Joe Hewitt (gone)]

Attachment: updated patch

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 51139 [details] [diff] [review]
updated patch

r=[e-mail]

Comment 11

[[e-mail]]

Three comments:
<xul:vbox class="box-inherit dialog-content-box" flex="1">
... inherit="align,dir,orient,pack"

+var list = aButtons.split(/[, ]+/);
-var list = aButtons.split(",");
-if (list.length == 1)
-  list = aButtons.split(" ");
 var shown = { accept: false, cancel: false, help: false, disclosure: false};
 for (var i = 0; i < list.length; ++i)
-  shown[list[i].replace(/ /g, "")] = true;
+  shown[list[i]] = true;

\ No newline at end of file

Comment 12

[Joe Hewitt (gone)]

Neil, the purpose of all that extra parsing code is to allow people to use comma
OR space delimited lists, and to trim extra whitespace.

Comment 13

[Joe Hewitt (gone)]

fixed.  I will open a new bug for moving all dialogs in the app to the new syntax.