Last Comment Bug 707570 - [SeaMonkey] "browser_bug435325.js:15 - ReferenceError: gPrefService is not defined"
: [SeaMonkey] "browser_bug435325.js:15 - ReferenceError: gPrefService is not de...
Status: VERIFIED FIXED
[perma-orange]
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- major (vote)
: mozilla12
Assigned To: Steffen Wilberg
:
: Andrew Overholt [:overholt]
Mentors:
http://mxr.mozilla.org/mozilla-centra...
Depends on:
Blocks: SmTestFail 592653 435325 699684
  Show dependency treegraph
 
Reported: 2011-12-04 14:43 PST by Serge Gautherie (:sgautherie)
Modified: 2012-02-26 00:53 PST (History)
5 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
wontfix
verified
affected


Attachments
patch [Checkin: Comments 6 and 12] (1.75 KB, patch)
2011-12-28 05:10 PST, Steffen Wilberg
bzbarsky: review+
akeybl: approval‑mozilla‑aurora+
akeybl: approval‑mozilla‑beta+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2011-12-04 14:43:36 PST
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1323030901.1323034450.12769.gz
OS X 10.6 comm-central-trunk debug test mochitest-other on 2011/12/04 12:35:01
{
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/docshell/test/browser/browser_bug435325.js | Exception thrown at chrome://mochitests/content/browser/docshell/test/browser/browser_bug435325.js:15 - ReferenceError: gPrefService is not defined

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/docshell/test/browser/browser_bug435325.js | Cleanup function threw an exception at chrome://mochitests/content/browser/docshell/test/browser/browser_bug435325.js:45 - ReferenceError: gPrefService is not defined
}
Comment 1 Philip Chee 2011-12-05 10:40:01 PST
Please use Services.prefs instead of gPrefService.
I don't see why Firefox is using a lazy getter here since Services.prefs is already a lazy getter. It can't get any lazier.
Comment 2 Steffen Wilberg 2011-12-28 05:10:46 PST
Created attachment 584555 [details] [diff] [review]
patch [Checkin: Comments 6 and 12]

Worth a try.
Comment 3 Steffen Wilberg 2011-12-28 05:37:11 PST
Looks like SeaMonkey doesn't define gPrefService globally like http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#134 does.

The test still passes locally.
Comment 4 Boris Zbarsky [:bz] (still a bit busy) 2011-12-28 14:51:35 PST
Comment on attachment 584555 [details] [diff] [review]
patch [Checkin: Comments 6 and 12]

r=me
Comment 6 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-12-30 05:05:47 PST
https://hg.mozilla.org/mozilla-central/rev/66b79f9ae14f
Comment 7 Serge Gautherie (:sgautherie) 2011-12-31 17:52:16 PST
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1325307514.1325311688.15214.gz&fulltext=1
OS X 10.6 comm-central-trunk debug test mochitest-other on 2011/12/30 20:58:34
{
[...]
TEST-PASS | [...]
INFO TEST-END | chrome://mochitests/content/browser/docshell/test/browser/browser_bug435325.js | finished in 963ms
}

V.Fixed
Comment 8 Serge Gautherie (:sgautherie) 2012-01-05 05:09:38 PST
Comment on attachment 584555 [details] [diff] [review]
patch [Checkin: Comments 6 and 12]

[Approval Request Comment]
Regression caused by (bug #): bug 435325
User impact if declined: none
Testing completed (on m-c, etc.): yes, comment 7
Risk to taking this patch (and alternatives if risky): no risk, test-only

This fixes a test and might (additionally) help with bug 699684 comment 3.
Comment 9 Alex Keybl [:akeybl] 2012-01-05 15:11:03 PST
Comment on attachment 584555 [details] [diff] [review]
patch [Checkin: Comments 6 and 12]

[Triage Comment]
Test-only fix - approved for aurora/beta.
Comment 10 Ed Morley [:emorley] 2012-02-05 11:22:58 PST
Adjusting whiteboard post uplift.
(I don't have a beta tree, or I'd check it in)
Comment 11 Steffen Wilberg 2012-02-06 01:04:32 PST
Aurora (v12), by uplift from mozilla-central:
https://hg.mozilla.org/releases/mozilla-aurora/rev/66b79f9ae14f

Still needs to land on mozilla-beta (v11).
Comment 12 Jens Hatlak (:InvisibleSmiley) 2012-02-25 03:07:46 PST
Comment on attachment 584555 [details] [diff] [review]
patch [Checkin: Comments 6 and 12]

http://hg.mozilla.org/releases/mozilla-beta/rev/7af76ad904df
Comment 13 Serge Gautherie (:sgautherie) 2012-02-26 00:46:23 PST
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1330216750.1330220892.12201.gz
OS X 10.5 comm-beta debug test mochitest-other on 2012/02/25 16:39:10

firefox11: verified.

Note You need to log in before you can comment on or make changes to this bug.